-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[env] add architecture type info to the fastlane env #19533
Open
Kukurijek
wants to merge
175
commits into
fastlane:master
Choose a base branch
from
Kukurijek:env-add-cpu-type
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
175 commits
Select commit
Hold shift + click to select a range
bd51ac0
add CPU type info to the fastlane env
a96b172
fixed typo (#19514)
Vannevelj d68d2aa
[action][set_github_release] fix issue where bad status code would pr…
joshdholtz a391c70
add architecture type to the fastlane env instead of CPU type
eaa7b9a
[match] nuke now supports filtering by specific certificates (#19584)
joshdholtz de58163
[match][cert] allow developer_id creation if using apple id (#19604)
joshdholtz 5c1621d
#17667 Added optional `skip_stapling` parameter to `notarize` action.…
macblazer 54d0fcd
[action][get_version_number] - search for MARKETING_VERSION in build …
nekrich 963e376
[fastlane_core] use -assetFile instead of -f for IPA upload with iTMS…
taylorfort afa2ce1
[pem] Add macOS platform support (#19564)
nekrich 1879cc2
[action][set_github_release] Support generate_release_notes parameter…
yutailang0119 9c59d31
[action][set_github_release] Fix optional params to guard (#19560)
yutailang0119 5dc9f74
Version bump to 2.198.0 (#19611)
joshdholtz d5a88ab
[fastlane_core] fix TransportExecutor to specifically look for ipa, d…
joshdholtz 5cf3bd8
[gym] Add xcodebuild_command option (#19614)
nekrich 1311131
[deliver] Resolves issue uploading iPad Pro 5th gen screenshots (#19616)
christianeiselt dac3164
Version bump to 2.198.1 (#19622)
joshdholtz 77be2c7
[action][download_dsyms] use filter argument to /builds to find speci…
tmm1 2668eff
[action][download_dsyms] fix: `download_dsyms` with `wait_for_dsym_pr…
bguidolim 8fa326a
[tests] fix failing master tests (#19677)
joshdholtz 4e8b5c8
[deliver][snapshot][fastlane_core] fix typos (#19675)
kraai de946dd
Add examples for simulator descriptions including OS version (#19683)
60583e0
[action] [update_code_signing_settings] add entitlements file path ca…
abcdev a6be336
[spaceship] spaceauth - add new functionality to check if a user's se…
justAnotherDev a79fa27
[action] allow using a `.xcode-version` file with `xcversion` action …
rogerluan 5d55364
[docs] modernize markdown syntax of auto-generated README documentati…
rogerluan 605d261
Version bump to 2.199.0 (#19693)
joshdholtz 8db4815
update license (#19757)
Kukurijek 3a97e72
[scan] Fix: test retries succeeding when they shouldn't (#19749)
EricAtomic eaf77b0
gym: Correctly inherit OTHER_SWIFT_FLAGS when using option 'analyze_b…
icecrystal23 594449e
Fix download-dsym unnecessary builds scan when `after_uploaded_date` …
GermanVelibekovHouzz 7df69c9
[deliver] Add Watch Series 7 screen size (#19782)
Empty2k12 bf117a1
Update get_version_number.rb (#19773)
dejunDev d0f135d
[fastlane_core] use randomly generated filename(s) for -assetFile whe…
dokimyj e04b8c3
[supply] add an option to change the release status of a promoted tra…
joeflateau 576e76b
[fastlane_core] fix non-UTF-8 char issues when analysing ipa (#19697)
chenshifei 5931981
[spaceship] Initial support for updated review submissions flow (#19751)
valerio-castelli e215bdc
Version bump to 2.200.0 (#19784)
joshdholtz 2533026
Remove XCPretty dependency and add xcbeautify as an option (#19629)
joshdholtz ea9ee12
[team] Update team.json (#19802)
lucgrabowski f995720
Fix Gemfile.lock versions
joshdholtz 142cefd
Version bump to 2.201.0 (#19822)
joshdholtz 9ebbbff
[scan][xcov] set xcresult path in SharedValues and use as default in …
joshdholtz 427e0c9
[trainer] Make new options used by scan public (to fix crash) (#19828)
joshdholtz cb3fbac
[scan] prevent error from raising and prevent xcresult processing whe…
joshdholtz bdf2336
Version bump to 2.201.1 (#19833)
joshdholtz 99c4c05
[scan] fix off by one for scan's number_of_retries with xcode 13 (#19…
joshdholtz 9b8ff3e
[scan] look for xcresult in derived data instead of forcing temp dir …
joshdholtz 39acd5d
[snapshot] fix tests if xcbeautify is installed (#19846)
joshdholtz 23f0dd0
Version bump to 2.201.2 (#19847)
joshdholtz 0c8137a
[deliver] migrate to new app store review process (#19838)
joshdholtz 6569fbc
Version bump to 2.202.0 (#19863)
joshdholtz e760be8
[scan] add parallel_testing option to scan (#19857)
tejassharma96 409b7c8
[scan] Return results when running scan (#19860)
tejassharma96 ef0937f
[scan] fix crash if no derived data (#19871)
joshdholtz bbdd8bb
Version bump to 2.203.0 (#19872)
joshdholtz 08f771e
[trainer][regression] fixes fail_build parameter which stopped workin…
dcacenabes 6dabcf5
[scan] Fix issue when scan failed to zip_build_products for `build_fo…
crazymanish bce3bb8
Fixes bug in string concatenation of verify_build error message (#19873)
77e732c
[Fastlane.swift] fixes issues with running on Apple Silicon #18502 (#…
kikeenrique 3e01df6
[match] Add an option to safe remove certs for nuke (#19617)
lucgrabowski 6d43cb6
[snapshop] update example devices included with xcode 13.1 (#19615)
dweekly 154d2c3
[pilot][upload_to_testflight] Send pkg to mac testflight when both ip…
lucgrabowski 0fa8f7e
Fix typo in Match::Storage::S3Storage#s3_object_path (#19870)
fotos be7d70a
[pilot] support internal groups for testflight (#19735)
horvathtamasattila 2abdffc
[snapshot][fastlane_core] Hotfix/simulator not starting Xcode 13 (#19…
MakakWasTaken 835c1b5
Version bump to 2.204.0 (#19886)
joshdholtz f200f0f
[spaceship][deliver][pilot] temporarily fix finding app by filtering …
joshdholtz 7a63fd9
Version bump to 2.204.1 (#19901)
joshdholtz d7b3626
Revert "[spaceship][deliver][pilot] temporarily fix finding app by fi…
joshdholtz a5919ae
Version bump to 2.204.2 (#19907)
joshdholtz 387ef45
Update options.rb (#19938)
Lutzifer 67a2290
[Fastlane.Swift] readPodspec: return map of [String: Any] (#19953)
Hais 158b249
fix compile error on macCatalyst (#19917)
philipparndt 66b49da
[pem][spaceship] update development push certificate type ID (#19879)
igor-makarov 2a77737
[Fastlane.Swift] Swift fastlane upgrader #18933 (#19914)
kikeenrique 74ffd23
[trainer] Identify skipped tests in `xcresult` and export to Junit fo…
igor-makarov 904fdf6
Version bump to 2.204.3 (#19958)
joshdholtz ae04d90
fix typos in comments and code (#20005)
Lutzifer a74e0eb
[trainer] Return Test Plan Configuration in JUnit output (#20016)
sebskuse 12e5fe5
[supply] Prefer all default tracks (#19926) (#20010)
tkorri 8e9c484
[spaceship] Add unresolved_issues to review submission states and upd…
VrsajkovIvan33 5346119
[action][git_commit action] use safer way of calling `sh` (#19978)
AliSoftware 3b41060
Add env var to skip printing plugins table. (#19963)
rogerluan 156f211
fix typo (#19962)
att55 3fa026d
[spaceship] replace teams endpoints (#20083)
joshdholtz 63759df
Version bump to 2.205.0 (#20084)
joshdholtz abd1063
[spaceship][tunes] fix 'block in select_team': [!] undefined method `…
nomunomu0504 74715ce
[trainer] reports failure with skipped tests (#20045)
tahirmt 29c285f
Added case-sensitive .DS_Store to gitignore (#20090)
668d976
Version bump to 2.205.1 (#20114)
joshdholtz acb7d84
match: Avoid mutating app_identifiers (#20125)
AliSoftware e9861e6
Add support for iPhone 13 device family with updated colors (#20148)
casperson 81277cd
[trainer] Fix missing test failures and improve junit format (#20105)
tahirmt c456d89
Revert "[trainer] Fix missing test failures and improve junit format …
joshdholtz baeb595
[spaceship] refresh token and retry on authorization errors (#19502)
andersonvom ab18b91
[match] Check validity of provisioning profile certificates (#20194)
nekrich 7508b63
[update_project_provisioning] Fail when profile cannot be verified (#…
lucgrabowski 90a0345
Version bump to 2.205.2 (#20203)
joshdholtz eb4584e
[infra] changelog will now show github usernames which makes contribu…
joshdholtz 2d78ca2
[spaceship] update `Spaceship::ConnectAPI::User model` to include `de…
liamnichols 3ba6927
[spaceship] update buildDeliveries request to use app id in path (#20…
lucgrabowski df11580
[fastlane] allows aliased tool names (build_app, sync_code_signing, e…
joshdholtz 7bae3dc
[action][danger] Add GitHub enterprise flags to Danger action (#20216)
alexanderwe 431f4d6
Added timeout param into setup_ci (#20211)
javigines eec82d5
Add option to skip google account confirmation (#20223)
trsneed 56279c7
[spaceship] fix creation App Store Connect API authorization token (#…
nnsnodnb 872266d
Remove named parameter from `create_capability` example. (#20197)
t2 1015e10
[scan] fix scan failing to return results when there are test failure…
tahirmt 2851a3d
[deliver] add `verify_only` option to deliver (#20247)
polpielladev 8d14d8b
[spaceship] Add ability to invite a single TestFlight user (#20112)
LcTwisk c76ef61
[match] Add support for Developer ID certificates from G2 Sub-CA (#20…
triplef de8b5ff
Version bump to 2.206.0 (#20288)
joshdholtz 4b5dd66
[specs] Fix import_from_git running on environment with non master de…
lacostej 024ef5c
[Regression][fastlane] Fixed fastlane command issue when tool name no…
crazymanish f2e4805
Version bump to 2.206.1 (#20308)
joshdholtz 1238c39
[fastlane][tests] add tests for CLIToolsDistributor (#20315)
lucgrabowski a32786a
Test on Ruby 3.1 (#20313)
lacostej a522c66
fix a grammatical mistake (#20307)
kamimi01 84ef480
Fixed encoding issue when saving p12 file. (#20317)
rogerluan af048a6
[Fastlane.Swift] Use ArgumentProcessor port to start fastlane socket_…
SvenTiigi b5ec603
[Fastlane.swift] fix compile issue with argumentProcessor (#20318)
joshdholtz 3bbaf61
Version bump to 2.206.2 (#20320)
joshdholtz c02fa82
Allow overriding the architecture to run xcodebuild under (#20323)
milch a0ac307
Update rack due to security alert from dependabot (#20339)
lucgrabowski f761923
Fix typo from uplaod to upload (#20331)
EmDee 6863892
[Ruby] Ruby 2.6 is now the minimum (dropping Ruby 2.5) (#20413)
joshdholtz 4ea6601
[snapshot] Add missing iPod touch to Generated Snapshot Reports (#20337)
kylehowells 4a8c27e
Specify s3 object prefix (#20344)
iaia 3f88926
[action][update_info_plist] improve the plist file-path option valida…
crazymanish b12c325
Add device Google Pixel 5 (#20389)
denrase 9459056
[pilot] added the Pilot::TesterExporter class unit tests (#20394)
crazymanish b989e9c
[fastlane-core][scan] added destination param support inside the `xco…
crazymanish 5d87104
[match] Added Match::CommandsGenerator's import option unit test (#20…
crazymanish efde04c
[match] Improved Match::CommandsGenerator's decrypt option unit test …
crazymanish cfcf2e8
[Match] Adding support for GitLab Secure Files as a Match storage mod…
darbyfrey 6a8969d
Show http error message from AppStore (#20397)
kalinjul 6f81747
[sigh][match][spaceship] add missing inhouse to mac profile types (#2…
DuMaM b7d5632
[spaceship] Allow for removing app from sale by updating territories …
lucgrabowski d407af5
[match] add imports, fix linting errors, rename env variable (#20418)
joshdholtz 019bad7
[deliver] update deliver/runner.rb to handle both ipa and pkg paths. …
snatchev 38a316f
[match] add profile_type filtering when checking if profile exists (#…
PaulTaykalo 3344301
Version bump to 2.207.0 (#20421)
joshdholtz 4e30b8b
[match] Fixes set up bugs when using GitLab Secure Files as a Match s…
darbyfrey 9d8470d
[scan] Fix ERB.new() deprecation warnings (#20440)
wallisch ac23bbc
[snapshot] Use empty string to blank out operator name by default (#2…
ZevEisenberg 9867fe7
[action][changelog_from_git_commits] Fix description for documentatio…
mbernson 6072f39
extract the certificate name from provisioning profiles (#20187)
tejassharma96 4b4a049
Add CircleCI connect instructions to PR template (#20453)
getaaron c7a5725
[match] [sigh] Add productsign to import script command (#20474)
DuMaM aa2fd75
[match][sigh] Prefer default keychain during wwdr cert installation (…
DuMaM 81275ea
[spaceship] fix `fastlane init` and temporarily retrofitting `Spacesh…
joshdholtz 0781d7e
Version bump to 2.208.0 (#20483)
joshdholtz c6ef9b1
[match] suppress null byte message (#20497)
getaaron f221c95
[pilot] app_version and app_build should not be fetched from a local …
tremblay ac06910
Don't create in lazy manner keychain files (#20478)
DuMaM ad01ea7
Fix unescaped \ (#20508)
aibaars 850593c
Adding no overwrite and local only options to the pod repo push comma…
polmum 203f195
[match][sigh][cert] Added checking hash of installed wwdr certificate…
grey442 67f763b
faceook.design moved to design.facebook.com (#20513)
guidev 1e45f92
Fix typo caused by string concatenation. (#20531)
rogerluan 3af8e03
Version bump to 2.209.0 (#20550)
joshdholtz 3df4169
Ignoring case sensitive when requesting SMS (#20436)
harrimaatta b8045bb
The word phrasing used has been standardized. (#20543)
mofmofmofneko 02acdea
[fastlane_core] install all Apple WWDR Intermediate Certificates (#20…
crazytonyli 259e8dd
Version bump to 2.209.1 (#20582)
joshdholtz ff41f35
Fix typo and improve phrasing of documentation. (#20585)
rogerluan b4070a8
[deliver][pilot] use altool instead of using iTMSTransporter for Xcod…
freddi-kit 5eaf30d
Version bump to 2.210.0 (#20660)
joshdholtz 9db0159
[pilot][deliver] Fix how to encode base64 p8 key on deliver and pilot…
freddi-kit 2720634
Version bump to 2.210.1 (#20682)
joshdholtz 950bb82
[deliver] add support to detecting and uploading 6.7" (iPhone 14 Pro …
cherpake 717de3e
add CPU type info to the fastlane env
aaae446
add architecture type to the fastlane env instead of CPU type
7be245c
Merge branch 'env-add-cpu-type' of github.com:Kukurijek/fastlane into…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add CPU type info to the fastlane env
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of CPU type, do we actually (or also) want the architecture type? This might be good to see if its running in Rosetta? This can be checked with
uname -p
orarch
. Thoughts? 😇There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @joshdholtz !
You are completely right. Information about the type of cpu is completely unnecessary if we know what the architecture is. On the other hand, maybe some users may find this information (CPU Info) sensitive, and since we don't need it, I replace it architecture type.
uname -p
returns a lot of information that is not needed (at least at this point 😄 ), so I changed the command toarch
which returns only type eg.i386
Thanks! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually
uname -p
returns the same thing asarch
. I used some other commando before 🤣. Anyway it works and PR is updated.