[env] add architecture type info to the fastlane env #19533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdholtz
requested changes
Oct 29, 2021
There was a problem hiding this comment.
@Kukurijek This is a great idea! Thoughts on either changing or adding if its running in arm or i386 (Rosetta)?
| # @return CPU type | ||
| def self.cpu_type | ||
| return "" unless self.mac? | ||
| return `sysctl -n machdep.cpu.brand_string`.split("\n").first |
There was a problem hiding this comment.
Instead of CPU type, do we actually (or also) want the architecture type? This might be good to see if its running in Rosetta? This can be checked with uname -p or arch. Thoughts? 😇
There was a problem hiding this comment.
Hi @joshdholtz !
You are completely right. Information about the type of cpu is completely unnecessary if we know what the architecture is. On the other hand, maybe some users may find this information (CPU Info) sensitive, and since we don't need it, I replace it architecture type.
uname -p returns a lot of information that is not needed (at least at this point 😄 ), so I changed the command to arch which returns only type eg. i386
Thanks! 🚀
There was a problem hiding this comment.
Actually uname -p returns the same thing as arch. I used some other commando before 🤣. Anyway it works and PR is updated.
…int error but fail silently - now actually raises an error (fastlane#19516)
…e#19584) * Initial logic to nuke by certificates * This so good * Thank you rubocop * Some improved error handling * Add interactive check and some more info
…settings if target has no INFO_PLIST (fastlane#19589) * get_version_number - search for MARKETING_VERSION in build settings if no plist for target * Update detail on action about looking at plist and then build settings Co-authored-by: Josh Holtz <me@joshholtz.com>
…fastlane#19596) * Workaround to validateAssets error for testflight upload * Undo change to ipa_upload_package_builder, add new argument to transporter for asset file, use asset file if exists and macos * Fix deliver tests Co-authored-by: Josh Holtz <me@joshholtz.com>
* pem: Add macOS platform support * A little cleanup * Fix some logic I broke and rework message Co-authored-by: Josh Holtz <me@joshholtz.com>
…mg, ipa, and zip and not directory for -assetFile and then fall bask to -f (fastlane#19620) * [fastlane_core] fix TransportExecutor to specifically look for ipa, dmg, ipa, and zip and not directory for -assetFile and then fall bask to -f * Added a way to force ITMSP if needed and added some more tests
…lane#19616) * [delivery] iPad Pro 12.9 5th gen. Fix * [delivery] iPad Pro 12.9 5th gen. Tests
…fic build (fastlane#19670) * [action][download_dsyms] fetch specific version * [spaceship][connect_api] add iterator that loads pages on demand * [action][download_dsyms] avoid loading all builds upfront * [action][download_dsyms] stop processing when uploaded_date has passed; break out of loop because we know results are sorted by -uploadedDate * [action][download_dsyms] request specific build number too * Fixed tests Co-authored-by: Josh Holtz <me@joshholtz.com>
…ocessing` is not checking the latest data from Connect API (fastlane#19523) * Fix: `download_dsyms` with `wait_for_dsym_processing` is not checking the latest data from Connect API * Added tests * Apply suggestions from code review Co-authored-by: Satoshi Namai <s.namai.09@gmail.com> * Fixed tests Co-authored-by: Josh Holtz <me@joshholtz.com> Co-authored-by: Satoshi Namai <s.namai.09@gmail.com>
* Fix misspellings * Add missing "do"
…e#19683) This reflects the behaviour in https://github.com/fastlane/fastlane/blob/f0b9bbe0c391f034d997ae2ce48bac567c29fa7e/scan/lib/scan/detect_values.rb#L116 and also tests such as https://github.com/fastlane/fastlane/blob/f0b9bbe0c391f034d997ae2ce48bac567c29fa7e/scan/spec/test_command_generator_spec.rb#L671
…ssion is still valid (fastlane#19658) * add new flag '--check_session' to spaceship * add 3 tests for '--check_session' flag * update documentation to include info about the '--check_session' flag
…astlane#19644) * Allow using a `.xcode-version` file with xcversion. * Fix syntax. * Move .xcode-verison read into default Co-authored-by: Josh Holtz <me@joshholtz.com>
…astlane#20448) * Fix priority of checks in WWDR * Use latest wwdr * Remove deprecated cert * Update tests * Apply suggestions from code review Co-authored-by: Aaron Brager <getaaron@gmail.com> * Rename function to match it's behaviour * Expect only one cert * Remove redundant code * Delete fake testers_file_path * Update fastlane_core/lib/fastlane_core/cert_checker.rb * Apply linter fixes * Make sure password is invalid for decryption Co-authored-by: Aaron Brager <getaaron@gmail.com>
…ip::Tunes::Application.find` (fastlane#20480) * Commiting before i go crazy * This better hopefully * Fixed require * Test lint * Lint this * Lint this * All tests green please * Huge comment block * Adding a deprecation message in console
* Version bump to 2.208.0 * Fix failing test
…IPA or PKG when distribute_only is set (fastlane#20488) * app_version and app_build should not be fetched from a local IPA or PKG when distribute_only is set * add a test for the new behavior, remove a duplicate test
Co-authored-by: Aaron Brager <getaaron@gmail.com>
…nd (fastlane#20455) Co-authored-by: Pablo Muina <pablom@etermax.com>
fastlane#20507) * Added checking hash of installed wwdr certificates Co-authored-by: Aaron Brager <getaaron@gmail.com>
* Ignoring case sensitive when requesting SMS * retrigger checks
e.g. MatchfileTemplate. Co-authored-by: Yusuke Arakawa <nekolaboratory@users.noreply.github.com>
…tlane#20537) * Install all Apple WWDRCA certificates instead of just G6 * Use the openssl rubygem to get certficiate subject * Install 'WWDRCA - G1' certificate * 'G2' certificate has a different OU * Use sha256 to identify WWDR certificates
…e 14 (fastlane#20631) * Use altool instead of using iTMSTransporter for Xcode 14 * fix linter error * fix linter error * fix linter error * use keyword function for transporter_for_selected_team Co-authored-by: Kohki Miki <giginet.net@gmail.com> * fix typo and move platform string handling * remove unecessary return * create should_use_altool * fix to use unless to make code one line Co-authored-by: Kohki Miki <giginet.net@gmail.com> * make code oneline by using unless Co-authored-by: Kohki Miki <giginet.net@gmail.com> * improve error message * fix to support apple connect api key * fix jwt check * fix to set? for boolean function * fix rubocup issue * fix rubocup issue * fix test * fix to call upload without replacement * fix typo * fix checking apikey available or not * fix to generate p8 file for every calling altool * PR review fixes (Remove unused file, autogenerated by uni-tests + improved verbose logs) * Fix itunes_transporter_spec.rb which was failing in Xcode14 https://github.com/fastlane/fastlane/pull/20631/files#r967653482 * Fix helper_spec.rb which was failing in Xcode14 https://github.com/fastlane/fastlane/pull/20631/files#r967653482 * support base64 key_content for using altool with appstore connect apikey * fix typo * fix to remove un-necessary begin Co-authored-by: Olivier Halligon <olivier@halligon.net> * fix to use unless Co-authored-by: Olivier Halligon <olivier@halligon.net> * improve showing error on UI Co-authored-by: Olivier Halligon <olivier@halligon.net> * fix to remove warning in altool executer * improve error log * add some small fix * fix code format * fix to remove unnecessary return Co-authored-by: Kohki Miki <giginet.net@gmail.com> * fix to use File.open() |p8| * fix to use mktmpdir for saving p8 temp * fix linter issue * fix to use wb option when making p8 file * add unit test for altool case * fix test format * remove space * support api json path * add some comment and fix code style * add comment about error info * compose return expression in one line Co-authored-by: Kohki Miki <giginet.net@gmail.com> * fix to use checking raise_error Co-authored-by: Kohki Miki <giginet.net@gmail.com> * use context for matching rpec * fix code's readability * fix lint * fix lint * fix lint * fix ids provider problem * add comments * add test for provider ids * fix api key condition to make code more readable * add more detailed comment * fix typo * improve specifying substring * fix index * fix altool providers output to parse json * fix code format * fix hash problem if user pass key via environment variable * remove unnecessary ! * fix null handle * dummy commit for test * dummy commit for test * change the implementation place of provider id parser * make absract method * add raise for not implemented functions Co-authored-by: Kohki Miki <giginet.net@gmail.com> Co-authored-by: Manish Rathi <i.am.manish.rathi@gmail.com> Co-authored-by: Olivier Halligon <olivier@halligon.net>
…fastlane#20669) * fix how to encode base64 * fix code format Co-authored-by: Olivier Halligon <olivier@halligon.net> * fix rubocop warning Co-authored-by: Olivier Halligon <olivier@halligon.net>
…Max) screenshots (fastlane#20694) * upload 6.7inch screenshots * Update deliver/spec/app_screenshot_spec.rb Co-authored-by: Roger Oba <rogerluan.oba@gmail.com> * fix * fix * Update deliver/lib/deliver/app_screenshot.rb Co-authored-by: Kohki Miki <giginet.net@gmail.com> * Update deliver/spec/app_screenshot_spec.rb Co-authored-by: Kohki Miki <giginet.net@gmail.com> * Update deliver/lib/deliver/app_screenshot.rb Co-authored-by: Kohki Miki <giginet.net@gmail.com> * Update deliver/lib/deliver/app_screenshot.rb Co-authored-by: Kohki Miki <giginet.net@gmail.com> * Update deliver/lib/deliver/app_screenshot.rb Co-authored-by: Kohki Miki <giginet.net@gmail.com> * revert Gemlock * Fix indendation. Co-authored-by: Roger Oba <rogerluan.oba@gmail.com> Co-authored-by: Kohki Miki <giginet.net@gmail.com>
… env-add-cpu-type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
Resolves #19532
Description
New variable
Architecturefor architecture type in thefastlane env(macOS only).For more information please see #19532
Testing Steps
run
fastlane envand check the result - you should be able to find information about your architecture below the swift version (macOS ONLY).