-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spaceship] add visionOS support for Connect API #22032
Conversation
@lucgrabowski any chance this could be merged? 🙏 I believe the test failure is unrelated to the changes. |
@triplef Ah yeah, the failure was due to some homebrew stuff on CI 😅 I just merged a fix in to |
485665e
to
a5cf765
Compare
Great, thanks @joshdholtz! I rebased. 👍 |
@triplef Thank you for rebasing! 🫶 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 😁
Thanks @joshdholtz! Would be great if this could be merged for the next release if there’s nothing else. 🙏 🚀 |
🤩 🙏 |
FWIW adding |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
This is a simple rebase of #21929 onto master because the original author has not been able to do so in the past month and it would be great to have this in Fastlane to (I think?) complete visionOS support.
The only difference to the original commit is that the changes in
spaceship/connect_api.rb
were discarded as master already contained the same addition of visionOS.Description
See #21929.
All credit goes to @yanniks for implementing the changes.
Testing Steps
I have used it to upload our visionOS app to App Store Connect using deliver.