[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divide everything into v1, v2, and common (unexported). #1149

Merged
merged 11 commits into from
Jun 27, 2022

Commits on Jun 17, 2022

  1. Divide everything into v1, v2, and common (unexported).

    Did some refactoring, like putting `firebaseConfig` into common.
    This means we have absolutely no dependencies on v1 in common or
    v2. Some files are left at the root because they were modified
    in other CLs that are outstanding and I want to linearize the
    changes to minimize conflicts.
    
    While working, I removed some legacy workarounds that should no
    longer apply. For example, we no longer need to load fireaseConfig
    from runtime config because all supported versions of the CLI
    set the FIREBASE_CONFIG environment variable. This meant we
    could remove all of setup.ts because all monkeypatches were for
    outdated runtimes. Since there is no longer an environment
    change between importing v1/index and a subpackage, I've gone
    ahead and exported the providers for v1 to minimize customer
    frustration with the v1 namespace.
    inlined committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    9388953 View commit details
    Browse the repository at this point in the history
  2. Fix dependency conflicts

    inlined committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    c0247ea View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2022

  1. Lint fixes

    inlined committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    59e44d5 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. Remove __trigger (#1150)

    * Remove __trigger
    
    * Lint fixes
    inlined committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    4092d43 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2022

  1. Divide everything into v1, v2, and common (unexported).

    Did some refactoring, like putting `firebaseConfig` into common.
    This means we have absolutely no dependencies on v1 in common or
    v2. Some files are left at the root because they were modified
    in other CLs that are outstanding and I want to linearize the
    changes to minimize conflicts.
    
    While working, I removed some legacy workarounds that should no
    longer apply. For example, we no longer need to load fireaseConfig
    from runtime config because all supported versions of the CLI
    set the FIREBASE_CONFIG environment variable. This meant we
    could remove all of setup.ts because all monkeypatches were for
    outdated runtimes. Since there is no longer an environment
    change between importing v1/index and a subpackage, I've gone
    ahead and exported the providers for v1 to minimize customer
    frustration with the v1 namespace.
    inlined committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    74e4779 View commit details
    Browse the repository at this point in the history
  2. Fix dependency conflicts

    inlined committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    74e6b89 View commit details
    Browse the repository at this point in the history
  3. Lint fixes

    inlined committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    cbce040 View commit details
    Browse the repository at this point in the history
  4. Remove __trigger (#1150)

    * Remove __trigger
    
    * Lint fixes
    inlined committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    1dc221e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1e086e1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    97e6526 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. Configuration menu
    Copy the full SHA
    a83ba0d View commit details
    Browse the repository at this point in the history