-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Divide everything into v1, v2, and common (unexported). #1149
Merged
Commits on Jun 17, 2022
-
Divide everything into v1, v2, and common (unexported).
Did some refactoring, like putting `firebaseConfig` into common. This means we have absolutely no dependencies on v1 in common or v2. Some files are left at the root because they were modified in other CLs that are outstanding and I want to linearize the changes to minimize conflicts. While working, I removed some legacy workarounds that should no longer apply. For example, we no longer need to load fireaseConfig from runtime config because all supported versions of the CLI set the FIREBASE_CONFIG environment variable. This meant we could remove all of setup.ts because all monkeypatches were for outdated runtimes. Since there is no longer an environment change between importing v1/index and a subpackage, I've gone ahead and exported the providers for v1 to minimize customer frustration with the v1 namespace.
Configuration menu - View commit details
-
Copy full SHA for 9388953 - Browse repository at this point
Copy the full SHA 9388953View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0247ea - Browse repository at this point
Copy the full SHA c0247eaView commit details
Commits on Jun 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 59e44d5 - Browse repository at this point
Copy the full SHA 59e44d5View commit details
Commits on Jun 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4092d43 - Browse repository at this point
Copy the full SHA 4092d43View commit details
Commits on Jun 26, 2022
-
Divide everything into v1, v2, and common (unexported).
Did some refactoring, like putting `firebaseConfig` into common. This means we have absolutely no dependencies on v1 in common or v2. Some files are left at the root because they were modified in other CLs that are outstanding and I want to linearize the changes to minimize conflicts. While working, I removed some legacy workarounds that should no longer apply. For example, we no longer need to load fireaseConfig from runtime config because all supported versions of the CLI set the FIREBASE_CONFIG environment variable. This meant we could remove all of setup.ts because all monkeypatches were for outdated runtimes. Since there is no longer an environment change between importing v1/index and a subpackage, I've gone ahead and exported the providers for v1 to minimize customer frustration with the v1 namespace.
Configuration menu - View commit details
-
Copy full SHA for 74e4779 - Browse repository at this point
Copy the full SHA 74e4779View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74e6b89 - Browse repository at this point
Copy the full SHA 74e6b89View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbce040 - Browse repository at this point
Copy the full SHA cbce040View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1dc221e - Browse repository at this point
Copy the full SHA 1dc221eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e086e1 - Browse repository at this point
Copy the full SHA 1e086e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97e6526 - Browse repository at this point
Copy the full SHA 97e6526View commit details
Commits on Jun 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a83ba0d - Browse repository at this point
Copy the full SHA a83ba0dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.