[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Divide everything into v1, v2, and common (unexported). #1149

Merged
merged 11 commits into from
Jun 27, 2022
Merged

Divide everything into v1, v2, and common (unexported). #1149

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9388953
Divide everything into v1, v2, and common (unexported).
inlined Jun 17, 2022
c0247ea
Fix dependency conflicts
inlined Jun 17, 2022
59e44d5
Lint fixes
inlined Jun 18, 2022
4092d43
Remove __trigger (#1150)
inlined Jun 24, 2022
74e4779
Divide everything into v1, v2, and common (unexported).
inlined Jun 17, 2022
74e6b89
Fix dependency conflicts
inlined Jun 17, 2022
cbce040
Lint fixes
inlined Jun 18, 2022
1dc221e
Remove __trigger (#1150)
inlined Jun 24, 2022
1e086e1
Merge remote-tracking branch 'origin/inlined.refactor' into inlined.r…
inlined Jun 26, 2022
97e6526
Move apps and utilities into common
inlined Jun 26, 2022
a83ba0d
Merge branch 'launch.next' into inlined.refactor
inlined Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Divide everything into v1, v2, and common (unexported). 
Did some refactoring, like putting `firebaseConfig` into common.
This means we have absolutely no dependencies on v1 in common or
v2. Some files are left at the root because they were modified
in other CLs that are outstanding and I want to linearize the
changes to minimize conflicts.

While working, I removed some legacy workarounds that should no
longer apply. For example, we no longer need to load fireaseConfig
from runtime config because all supported versions of the CLI
set the FIREBASE_CONFIG environment variable. This meant we
could remove all of setup.ts because all monkeypatches were for
outdated runtimes. Since there is no longer an environment
change between importing v1/index and a subpackage, I've gone
ahead and exported the providers for v1 to minimize customer
frustration with the v1 namespace.
  • Loading branch information
@inlined
inlined committed Jun 17, 2022
commit 9388953eeb85bb6ab786d78eae30b0e0f77413a4
6 changes: 5 additions & 1 deletion integration_test/firebase.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,9 @@
"firestore": {
"rules": "firestore.rules",
"indexes": "firestore.indexes.json"
},
"functions": {
"source": "functions",
"codebase": "integration-tests"
}
}
}
4 changes: 2 additions & 2 deletions integration_test/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ function deploy {
./functions/node_modules/.bin/tsc -p functions/
# Deploy functions, and security rules for database and Firestore. If the deploy fails, retry twice
if [[ "${TOKEN}" == "" ]]; then
for i in 1 2 3; do firebase deploy --project="${PROJECT_ID}" --only functions,database,firestore && break; done
for i in 1 2 3; do firebase deploy --project="${PROJECT_ID}" --only functions:integration-tests,database,firestore && break; done
else
for i in 1 2 3; do firebase deploy --project="${PROJECT_ID}" --token="${TOKEN}" --only functions,database,firestore && break; done
for i in 1 2 3; do firebase deploy --project="${PROJECT_ID}" --token="${TOKEN}" --only functions:integration-tests,database,firestore && break; done
fi
}

Expand Down
Loading