Text snaps to pixel grid, images don't #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -52,7 +52,7 @@ double Paragraph::ideographicBaseline() | |||
|
|
|||
| void Paragraph::layout() | |||
| { | |||
| FontCachePurgePreventer fontCachePurgePreventer; | |||
| FontCachePurgePreventer fontCachePurgePreventer; | |||
There was a problem hiding this comment.
not that i care, but fyi there's a new trailing space here
There was a problem hiding this comment.
SHUT DOWN EVERYTHING
|
I would think the text renderer might want to know the sub-pixel positioning itself. But this will probably work for now. |
Previously, we tried to use the render tree's paint offset to move the text to the proper position, but that appears to snap to integer logical pixels, introducing jitter. Now we use the SkCanvas's matrix to position the text, removing the jitter. Fixes flutter/flutter#234
Yeah, unfortunately there's no way for it to know (on the web too) because you might have a transform higher in the tree that's changed your coordinate system. |
abarth
added a commit
that referenced
this pull request
Nov 20, 2015
Text snaps to pixel grid, images don't
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
* 0.1.116 * typo * typo * marked no_default_cases as experimental
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we tried to use the render tree's paint offset to move the text to
the proper position, but that appears to snap to integer logical pixels,
introducing jitter. Now we use the SkCanvas's matrix to position the text,
removing the jitter.
Fixes flutter/flutter#234