[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text snaps to pixel grid, images don't #234

Closed
FlutterIssues opened this issue Nov 9, 2015 · 2 comments
Closed

Text snaps to pixel grid, images don't #234

FlutterIssues opened this issue Nov 9, 2015 · 2 comments
Assignees
@abarth
Labels
engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels.

Comments

@FlutterIssues
Copy link

Issue by Hixie
Monday Oct 26, 2015 at 22:35 GMT
Originally opened as https://github.com/flutter/engine/issues/1811

Set your timeDilation factor to 100, then run the card collection app and overscroll the drawer by a lot. Watch the text and images as they scroll back down. The text looks like it's shaking up and down compared to the smoothly moving images.
@FlutterIssues FlutterIssues added this to the Blue Sky milestone Nov 9, 2015
@FlutterIssues FlutterIssues added bug framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine repository. See also e: labels. labels Nov 9, 2015
@abarth abarth self-assigned this Nov 18, 2015
@abarth
Copy link
Contributor
abarth commented Nov 20, 2015

I have the repro.

abarth added a commit to abarth/engine that referenced this issue Nov 20, 2015
@abarth
Text snaps to pixel grid, images don't
d12e614 
Previously, we tried to use the render tree's paint offset to move the text to
the proper position, but that appears to snap to integer logical pixels,
introducing jitter. Now we use the SkCanvas's matrix to position the text,
removing the jitter.

Fixes flutter/flutter#234
@abarth abarth mentioned this issue Nov 20, 2015
Merged
abarth added a commit to abarth/engine that referenced this issue Nov 20, 2015
@abarth
Text snaps to pixel grid, images don't
15a6383 
Previously, we tried to use the render tree's paint offset to move the text to
the proper position, but that appears to snap to integer logical pixels,
introducing jitter. Now we use the SkCanvas's matrix to position the text,
removing the jitter.

Fixes flutter/flutter#234
@jamesgopinath jamesgopinath mentioned this issue Aug 4, 2017
Closed
@steele232 steele232 mentioned this issue Nov 9, 2017
Closed
@kuochaoyi kuochaoyi mentioned this issue Mar 28, 2018
Closed
@micrcx micrcx mentioned this issue Mar 31, 2018
Closed
@Rockvole Rockvole mentioned this issue Apr 16, 2018
Closed
@efidje efidje mentioned this issue May 8, 2018
Closed
@shallquist shallquist mentioned this issue May 14, 2018
Closed
@JigneshWorld JigneshWorld mentioned this issue May 21, 2018
Closed
@sahil311289 sahil311289 mentioned this issue Jun 23, 2018
Closed
This was referenced Jul 19, 2018
Closed
Closed
@codeZee codeZee mentioned this issue Jul 29, 2018
Closed
@yogesh45 yogesh45 mentioned this issue Jul 31, 2018
Closed
@yubrshen yubrshen mentioned this issue Aug 2, 2018
Closed
@dadmad817 dadmad817 mentioned this issue Aug 8, 2018
Closed
@cathalgreaney cathalgreaney mentioned this issue Aug 12, 2018
Closed
@Saurabh-Singh-00 Saurabh-Singh-00 mentioned this issue Sep 2, 2018
Closed
@versluisant versluisant mentioned this issue Sep 28, 2018
Closed
@g-balas g-balas mentioned this issue Dec 10, 2018
Closed
@cuikun cuikun mentioned this issue Dec 23, 2018
Closed
This was referenced Oct 1, 2019
Closed
Closed
Closed
Closed
@ckartik ckartik mentioned this issue Oct 23, 2019
Closed
@dragon9ex dragon9ex mentioned this issue Nov 1, 2019
Closed
@daniele777 daniele777 mentioned this issue Dec 9, 2019
Closed
This was referenced Dec 16, 2019
Closed
Closed
This was referenced Dec 17, 2019
Closed
Closed
This was referenced Jan 4, 2020
Closed
Closed
This was referenced Jan 11, 2020
Closed
Closed
Closed
@viratshukla viratshukla mentioned this issue Jan 16, 2020
Closed
@azheennn azheennn mentioned this issue Jan 19, 2020
Closed
@varunkamani varunkamani mentioned this issue Mar 4, 2020
Closed
@GLopesRio GLopesRio mentioned this issue Mar 18, 2020
Closed
@davidakinfenwa davidakinfenwa mentioned this issue May 5, 2020
Closed
@vipuluthaiah vipuluthaiah mentioned this issue Jun 16, 2020
Closed
@pritsorathiya5181 pritsorathiya5181 mentioned this issue Aug 8, 2020
Closed
@verinder84 verinder84 mentioned this issue Aug 29, 2020
Closed
@l1x2d3 l1x2d3 mentioned this issue Sep 8, 2020
Closed
@flow-rajkarthik flow-rajkarthik mentioned this issue Sep 10, 2020
Closed
@dahmaular dahmaular mentioned this issue Sep 15, 2020
Closed
@subhashDev11 subhashDev11 mentioned this issue Nov 28, 2020
Closed
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abarth abarth

Labels
engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abarth @FlutterIssues