-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FontVariation.lerp, custom FontVariation constructors, and more documentation #43750
Conversation
3c83dad
to
586a63c
Compare
…entation This should aid with implementing the framework side of flutter/flutter#105120 This should also address flutter/flutter#28543.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for adding all this documentation!
@eyebrowsoffire when you approved it, did you see my previous post? I think there's a typo. |
@feinstein Can you point out the typo? I'm not sure where you mean. |
@Hixie I did on my previous comment, it says |
…re documentation" (#44993) Reverts #43750 Looks like this is having trouble rolling into the framework: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/62845/overview
@feinstein Thanks. I don't see your earlier comment anywhere, but I shall endeavour to include a fix when I reland this patch (it had to be reverted for other reasons)! |
Follow-up in #44996. |
…133139) flutter/engine@7d56840...72a0642 2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from ee7404db8273 to d0c369eaa637 (1 revision) (flutter/engine#44997) 2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from d0d2b7042bb9 to ee7404db8273 (1 revision) (flutter/engine#44995) 2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from eac8f8ea2660 to d0d2b7042bb9 (1 revision) (flutter/engine#44994) 2023-08-23 zanderso@users.noreply.github.com Revert "FontVariation.lerp, custom FontVariation constructors, and more documentation" (flutter/engine#44993) 2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from aa208c8a2d60 to eac8f8ea2660 (1 revision) (flutter/engine#44992) 2023-08-23 dkwingsmt@users.noreply.github.com Move Rasterizer::Draw's discard_callback to Delegate (flutter/engine#44813) 2023-08-23 ian@hixie.ch FontVariation.lerp, custom FontVariation constructors, and more documentation (flutter/engine#43750) 2023-08-23 ian@hixie.ch Make web tests start with an empty title (flutter/engine#43846) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…entation (#44996) This should aid with implementing the framework side of flutter/flutter#105120. This should also address flutter/flutter#28543. This is a reland of #43750 with two changes, one to fix a typo mentioned in #43750 (comment), and one to fix the analysis error found when rolling this to the framework (https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/62845/overview). The latter change is temporary and can be relaxed when FontVariations is reexported from dart:ui. I plan to do that when fixing flutter/flutter#105120.
…entation (#45030) This should aid with implementing the framework side of flutter/flutter#105120. This should also address flutter/flutter#28543. Original commit in #43750 was reverted in #44993. Second attempt in #44996 was reverted in #45023.
…entation (flutter#43750) This should aid with implementing the framework side of flutter/flutter#105120 This should also address flutter/flutter#28543.
…re documentation" (flutter#44993) Reverts flutter#43750 Looks like this is having trouble rolling into the framework: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/62845/overview
…entation (flutter#44996) This should aid with implementing the framework side of flutter/flutter#105120. This should also address flutter/flutter#28543. This is a reland of flutter#43750 with two changes, one to fix a typo mentioned in flutter#43750 (comment), and one to fix the analysis error found when rolling this to the framework (https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/62845/overview). The latter change is temporary and can be relaxed when FontVariations is reexported from dart:ui. I plan to do that when fixing flutter/flutter#105120.
…entation (flutter#45030) This should aid with implementing the framework side of flutter/flutter#105120. This should also address flutter/flutter#28543. Original commit in flutter#43750 was reverted in flutter#44993. Second attempt in flutter#44996 was reverted in flutter#45023.
This should aid with implementing the framework side of flutter/flutter#105120 This should also address flutter/flutter#28543.