[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontVariation.lerp, custom FontVariation constructors, and more documentation #44996

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

Hixie
Copy link
Contributor
@Hixie Hixie commented Aug 23, 2023

This should aid with implementing the framework side of flutter/flutter#105120.
This should also address flutter/flutter#28543.

This is a reland of #43750 with two changes, one to fix a typo mentioned in #43750 (comment), and one to fix the analysis error found when rolling this to the framework (https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/62845/overview). The latter change is temporary and can be relaxed when FontVariations is reexported from dart:ui. I plan to do that when fixing flutter/flutter#105120.

…entation

This should aid with implementing the framework side of flutter/flutter#105120
This should also address flutter/flutter#28543.
Copy link
Contributor
@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2023
@auto-submit auto-submit bot merged commit ac1ad18 into flutter:main Aug 23, 2023
27 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023
zanderso added a commit that referenced this pull request Aug 23, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023
zanderso added a commit that referenced this pull request Aug 23, 2023
zanderso added a commit that referenced this pull request Aug 23, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 23, 2023
…133211)

flutter/engine@58dc868...27d75f6

2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from 76898dad9fda to a631fefdba37 (2 revisions) (flutter/engine#45027)
2023-08-23 zanderso@users.noreply.github.com Revert "FontVariation.lerp, custom FontVariation constructors, and more documentation" (flutter/engine#45023)
2023-08-23 bdero@google.com [Impeller] Dat rvalue reference (fix engine head) (flutter/engine#45024)
2023-08-23 bdero@google.com Revert "Enable clang-tidy for pre-push (opt-out), exclude `performance-unnecessary-value-param`" (flutter/engine#45020)
2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from 4e42b51cfe27 to 76898dad9fda (1 revision) (flutter/engine#45019)
2023-08-23 bdero@google.com [Impeller] Add STB text backend. (flutter/engine#44887)
2023-08-23 reidbaker@google.com Followup to flutter/engine#44982 (flutter/engine#45018)
2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from 5428f147e632 to 4e42b51cfe27 (4 revisions) (flutter/engine#45016)
2023-08-23 reidbaker@google.com Eliminate android test log spam (flutter/engine#44982)
2023-08-23 mdebbar@google.com [web] Remove some unused functions (flutter/engine#44505)
2023-08-23 lhkbob@gmail.com Use decal TileMode in blur image_filter_test.dart (flutter/engine#45004)
2023-08-23 ian@hixie.ch FontVariation.lerp, custom FontVariation constructors, and more documentation (flutter/engine#44996)
2023-08-23 jonahwilliams@google.com [impeller] combine sampler and texture maps. (flutter/engine#44990)
2023-08-23 bdero@google.com [Impeller] Flutter GPU: Add HostBuffer. (flutter/engine#44696)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot pushed a commit that referenced this pull request Aug 25, 2023
…entation (#45030)

This should aid with implementing the framework side of flutter/flutter#105120.
This should also address flutter/flutter#28543.

Original commit in #43750 was reverted in #44993.
Second attempt in #44996 was reverted in #45023.
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
…entation (flutter#44996)

This should aid with implementing the framework side of flutter/flutter#105120.
This should also address flutter/flutter#28543.

This is a reland of flutter#43750 with two changes, one to fix a typo mentioned in flutter#43750 (comment), and one to fix the analysis error found when rolling this to the framework (https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/62845/overview). The latter change is temporary and can be relaxed when FontVariations is reexported from dart:ui. I plan to do that when fixing flutter/flutter#105120.
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
…entation (flutter#45030)

This should aid with implementing the framework side of flutter/flutter#105120.
This should also address flutter/flutter#28543.

Original commit in flutter#43750 was reverted in flutter#44993.
Second attempt in flutter#44996 was reverted in flutter#45023.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
2 participants