[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify osv-scanner workflow #49807

Merged
merged 14 commits into from
Jan 18, 2024
Merged

Conversation

sealesj
Copy link
Contributor
@sealesj sealesj commented Jan 16, 2024

This change simplifies the osv-scanner workflow by extracting dependencies from the DEPS file and then finding their common ancestor commit with upstream in one script.

Fixes: flutter/flutter#141184

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@sealesj
Copy link
Contributor Author
sealesj commented Jan 17, 2024

It looks like this update on the osv-scanner side broke our workflow since v3 upload actions cannot be paired with v4 download actions.

@sealesj sealesj marked this pull request as ready for review January 17, 2024 21:37
@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 18, 2024
@auto-submit auto-submit bot merged commit 75400c4 into flutter:main Jan 18, 2024
27 checks passed
@sealesj sealesj deleted the simplify_osv_scanner branch January 18, 2024 18:49
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 18, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 18, 2024
…141796)

flutter/engine@de68e76...75400c4

2024-01-18 103135467+sealesj@users.noreply.github.com Simplify osv-scanner workflow (flutter/engine#49807)
2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from b1611add5939 to 1064eeedac09 (6 revisions) (flutter/engine#49867)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App vulnerability scan
Projects
None yet
2 participants