[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify engine osv-scanner workflow #141184

Closed
sealesj opened this issue Jan 9, 2024 · 1 comment · Fixed by flutter/engine#49807
Closed

Simplify engine osv-scanner workflow #141184

sealesj opened this issue Jan 9, 2024 · 1 comment · Fixed by flutter/engine#49807
Assignees
@sealesj
Labels
team-infra Owned by Infrastructure team

Comments

@sealesj
Copy link
Contributor
sealesj commented Jan 9, 2024

The osv-scanner workflow in flutter/engine is using two scripts in the vulnerability parsing and scanning workflow, but those can be simplified to on single script. These should be merged, and associated code simplified.
@sealesj sealesj added the team-infra Owned by Infrastructure team label Jan 9, 2024
@sealesj sealesj self-assigned this Jan 9, 2024
@sealesj sealesj mentioned this issue Jan 9, 2024
Merged
8 tasks
@sealesj sealesj mentioned this issue Jan 16, 2024
Merged
8 tasks
auto-submit bot pushed a commit to flutter/engine that referenced this issue Jan 18, 2024
@sealesj
Simplify osv-scanner workflow (#49807)
75400c4 
This change simplifies the osv-scanner workflow by extracting dependencies from the DEPS file and then finding their common ancestor commit with upstream in one script.

Fixes: flutter/flutter#141184

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@github-actions GitHub Actions
Copy link
github-actions bot commented Feb 1, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sealesj sealesj

Labels
team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify osv-scanner workflow sealesj/engine
1 participant
@sealesj