[go: nahoru, domu]
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter Loading
base: ace9181172b6
Choose a base ref
...
head repository: flutter/flutter Loading
compare: 75a2e5b4932a
Choose a head ref
  • 16 commits
  • 41 files changed
  • 7 contributors

Commits on Jan 29, 2024

  1. Marks Mac_pixel_7pro native_assets_android to be unflaky (#141675) 

    <!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_pixel_7pro native_assets_android"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_pixel_7pro%20native_assets_android%22).
This test can be marked as unflaky.
    @fluttergithubbot
    fluttergithubbot committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    9207b85 View commit details
    Browse the repository at this point in the history

  2. Revert "Reland: "Fix how Gradle resolves Android plugin" (#137115)" (#… 

    …142464)

This reverts commit f5ac225, i.e. #137115.

This is a continuation of #142266 that was redone based on feedback to make this easier to revert in the future. The exact steps I took to create this revert:

1. Revert commit noted above
2. Fix merge conflicts, that notably involved reverting some changes in #140744 ~and #141417 (fixed my merge to avoid the second PR from being affected)
3. Delete `packages/flutter_tools/test/integration.shard/android_plugin_skip_unsupported_test.dart` as this was added in the commit noted above

cc @Gustl22 since I couldn't tag as a reviewer
    @camsim99
    camsim99 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    995e3fa View commit details
    Browse the repository at this point in the history

  3. Roll Flutter Engine from bedafa8794b6 to e21208583956 (1 revision) (#… 

    …142483)

flutter/engine@bedafa8...e212085

2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from 3680286e6bf4 to 0327d5b319fc (1 revision) (flutter/engine#50150)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    8d14d31 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Roll Flutter Engine from e21208583956 to c9268c7db03c (1 revision) (#… 

    …142492)

flutter/engine@e212085...c9268c7

2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from 0327d5b319fc to c1899b2586da (3 revisions) (flutter/engine#50152)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    9c16653 View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from c9268c7db03c to 65bf8b1db4d1 (1 revision) (#… 

    …142496)

flutter/engine@c9268c7...65bf8b1

2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from c1899b2586da to 09379d00b455 (3 revisions) (flutter/engine#50156)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d5b189c View commit details
    Browse the repository at this point in the history

  3. Roll Flutter Engine from 65bf8b1db4d1 to df5f1afd4991 (1 revision) (#… 

    …142501)

flutter/engine@65bf8b1...df5f1af

2024-01-29 johnoneil@users.noreply.github.com Enable `_Float16` "half-float" Functionality Only When Available. (flutter/engine#49851)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    4c62abd View commit details
    Browse the repository at this point in the history

  4. Roll Flutter Engine from df5f1afd4991 to 5584a78a439b (2 revisions) (#… 

    …142503)

flutter/engine@df5f1af...5584a78

2024-01-30 matanlurey@users.noreply.github.com Revert: "Change how OpenGL textures are flipped in the Android embedder" (flutter/engine#50158)
2024-01-30 john@johnmccutchan.com Re-Re-land Manually revert TLHC optimizations (flutter/engine#50155)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    bce0a84 View commit details
    Browse the repository at this point in the history

  5. Roll Flutter Engine from 5584a78a439b to ed73d40a8c93 (1 revision) (#… 

    …142504)

flutter/engine@5584a78...ed73d40

2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 09379d00b455 to 083c1a4d9767 (1 revision) (flutter/engine#50162)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    5c64d03 View commit details
    Browse the repository at this point in the history

  6. Organize leak tracking TODOs. (#142460)

    @polina-c
    polina-c committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    6dff3da View commit details
    Browse the repository at this point in the history

  7. Roll Flutter Engine from ed73d40a8c93 to 438e9b4d7d4e (1 revision) (#… 

    …142508)

flutter/engine@ed73d40...438e9b4

2024-01-30 mbrase@google.com Fix incorrect FML_VLOG() severity usage (flutter/engine#50118)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    40ecbc8 View commit details
    Browse the repository at this point in the history

  8. Using initExpensiveAndroidView for Android Hybrid Composition Mode (#… 

    …142399)

After #100990, we should use `initExpensiveAndroidView` for Android Hybrid Composition mode instead of `initSurfaceAndroidView`. 

`initSurfaceAndroidView` attempts to use `TLHC` when possible. In cases where that is not supported, it falls back to using Hybrid Composition.

flutter/engine#49414
    @0xZOne
    0xZOne committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    ccb2b44 View commit details
    Browse the repository at this point in the history

  9. Roll Flutter Engine from 438e9b4d7d4e to 0e586d1c28c8 (4 revisions) (#… 

    …142515)

flutter/engine@438e9b4...0e586d1

2024-01-30 jonahwilliams@google.com [Impeller] Add interface for submitting multiple command buffers at once. (flutter/engine#50139)
2024-01-30 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.3.0 (flutter/engine#50165)
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 083c1a4d9767 to 4e992fb3a9db (1 revision) (flutter/engine#50164)
2024-01-30 mbrase@google.com Use structured logging on Fuchsia (flutter/engine#49918)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    72dc162 View commit details
    Browse the repository at this point in the history

  10. Roll Packages from 516648a to 25abb5d (6 revisions) (#142527) 

    flutter/packages@516648a...25abb5d

2024-01-30 tessertaha@gmail.com [rfw] Add `OverflowBar` widget and Update `ButtonBar` widget implementation (flutter/packages#5807)
2024-01-30 stuartmorgan@google.com [ci] Reduce tasks slightly (flutter/packages#6011)
2024-01-29 stuartmorgan@google.com Clarify issue requirement (flutter/packages#6010)
2024-01-29 stuartmorgan@google.com [various] Disambiguate TestDefaultBinaryMessengerBinding (flutter/packages#6009)
2024-01-29 engine-flutter-autoroll@skia.org Manual roll Flutter from a8efa77 to 2f6fdf2 (23 revisions) (flutter/packages#6008)
2024-01-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.1 to 3.23.2 (flutter/packages#5987)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    461f0bf View commit details
    Browse the repository at this point in the history

  11. Roll Flutter Engine from 0e586d1c28c8 to f02a4a80a77e (3 revisions) (#… 

    …142528)

flutter/engine@0e586d1...f02a4a8

2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 1c0eae94fc09 to 7dc9ba2e8c90 (1 revision) (flutter/engine#50169)
2024-01-30 skia-flutter-autoroll@skia.org Roll Skia from 4e992fb3a9db to 1c0eae94fc09 (3 revisions) (flutter/engine#50167)
2024-01-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Hqi_x_A9lYsY58VSn... to Z-xFM2ILZJw22eU8q... (flutter/engine#50166)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Hqi_x_A9lYsY to Z-xFM2ILZJw2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    5bb4fa3 View commit details
    Browse the repository at this point in the history

  12. Fix SliverMainAxisGroup geometry cacheExtent (#142482) 

    Fixes #142183

This fixes a bug in the SliverGeometry of SliverMainAxisGroup. The cacheExtent represents how many pixels the sliver has consumed in the SliverConstraints.remainingCacheExtent. Since it was not set, slivers that came after a SliverMainAxisGroup that filled the whole screen did not properly lay out their own children, in some cases making lazy sliver more eager than they should be.
    @Piinks
    Piinks committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    e8cb029 View commit details
    Browse the repository at this point in the history

  13. Reset framesEnabled to default value at the end of each test (#141844) 

    Reset `framesEnabled` to `true` at the end of each test as otherwise subsequent tests may fail when pumping a widget

Fixes #141835
    @aizatazhar
    aizatazhar committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    75a2e5b View commit details
    Browse the repository at this point in the history
Loading