[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo korean, cutButtonLabel #151364

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

n7484443
Copy link
@n7484443 n7484443 commented Jul 6, 2024

Wikipeidia
In korea, we use '잘라내기', '복사', '붙여넣기', not '잘라냄', '복사', '붙여넣기'.
image
e.g.) korean translation site, papago

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository labels Jul 6, 2024
@n7484443 n7484443 force-pushed the master branch 2 times, most recently from 12b7793 to 67cbc41 Compare July 11, 2024 14:39
@Piinks Piinks requested a review from justinmc July 11, 2024 18:29
@justinmc justinmc requested a review from LouiseHsu July 11, 2024 19:47
Copy link
Contributor
@LouiseHsu LouiseHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! do you think you could add a test like this?https://github.com/flutter/flutter/pull/142158/files#diff-484416bbc51eb0d169f9a783e719250552133dd063f117dd45c7ec445d2ef54c

Otherwise this looks good!

@LouiseHsu
Copy link
Contributor

I've also requested a translation change internally here
https://localizer.google.com/messages/edittranslation/Flutter/3991031067551493329/ko

@n7484443
Copy link
Author

Thank you for your PR! do you think you could add a test like this?https://github.com/flutter/flutter/pull/142158/files#diff-484416bbc51eb0d169f9a783e719250552133dd063f117dd45c7ec445d2ef54c

Otherwise this looks good!

As per your suggestion, I added the related test code to cut-copy-paste action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants