[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typo korean, cutButtonLabel #151364

Merged
merged 3 commits into from
Jul 16, 2024
Merged

chore: fix typo korean, cutButtonLabel #151364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28d247a
chore: fix typo korean, cutButtonLabel
n7484443 Jul 6, 2024
dd3baaf
regenerate localizations.dart
n7484443 Jul 6, 2024
766f02b
test: add test for korean, 'cut, copy, paste' button label
n7484443 Jul 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/flutter_localizations/lib/src/l10n/cupertino_ko.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"timerPickerMinuteLabelOther": "분",
"timerPickerSecondLabelOne": "초",
"timerPickerSecondLabelOther": "초",
"cutButtonLabel": "잘라냄",
"cutButtonLabel": "잘라내기",
"copyButtonLabel": "복사",
"pasteButtonLabel": "붙여넣기",
"selectAllButtonLabel": "전체 선택",
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_localizations/lib/src/l10n/generated_cupertino_localizations.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7758,7 +7758,7 @@ class CupertinoLocalizationKo extends GlobalCupertinoLocalizations {
String get copyButtonLabel => '복사';

@override
String get cutButtonLabel => '잘라냄';
String get cutButtonLabel => '잘라내기';

@override
String get datePickerDateOrderString => 'ymd';
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24330,7 +24330,7 @@ class MaterialLocalizationKo extends GlobalMaterialLocalizations {
String get currentDateLabel => '오늘';

@override
String get cutButtonLabel => '잘라냄';
String get cutButtonLabel => '잘라내기';

@override
String get dateHelpText => 'yyyy.mm.dd';
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_localizations/lib/src/l10n/material_ko.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"closeButtonLabel": "닫기",
"continueButtonLabel": "계속",
"copyButtonLabel": "복사",
"cutButtonLabel": "잘라냄",
"cutButtonLabel": "잘라내기",
"scanTextButtonLabel": "텍스트 스캔",
"okButtonLabel": "확인",
"pasteButtonLabel": "붙여넣기",
Expand Down
10 changes: 10 additions & 0 deletions packages/flutter_localizations/test/cupertino/translations_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,16 @@ void main() {
expect(localizations.lookUpButtonLabel, '查询');
});

testWidgets('ko-KR translation for cut, copy, paste label in ButtonLabel', (WidgetTester tester) async {
const Locale locale = Locale('ko');
expect(GlobalCupertinoLocalizations.delegate.isSupported(locale), isTrue);
final CupertinoLocalizations localizations = await GlobalCupertinoLocalizations.delegate.load(locale);
expect(localizations, isA<CupertinoLocalizationKo>());
expect(localizations.cutButtonLabel, '잘라내기');
expect(localizations.copyButtonLabel, '복사');
expect(localizations.pasteButtonLabel, '붙여넣기');
});

testWidgets('localizations.datePickerDayOfMonth uses the current locale for weekdays', (WidgetTester tester) async {
const Locale locale = Locale('zh');
expect(GlobalCupertinoLocalizations.delegate.isSupported(locale), isTrue);
Expand Down
10 changes: 10 additions & 0 deletions packages/flutter_localizations/test/material/translations_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,4 +559,14 @@ void main() {
expect(localizations, isA<MaterialLocalizationZh>());
expect(localizations.lookUpButtonLabel, '查询');
});

testWidgets('zh-CN translation for look up label', (WidgetTester tester) async {
const Locale locale = Locale('ko');
expect(GlobalCupertinoLocalizations.delegate.isSupported(locale), isTrue);
final MaterialLocalizations localizations = await GlobalMaterialLocalizations.delegate.load(locale);
expect(localizations, isA<MaterialLocalizationKo>());
expect(localizations.cutButtonLabel, '잘라내기');
expect(localizations.copyButtonLabel, '복사');
expect(localizations.pasteButtonLabel, '붙여넣기');
});
}