[go: nahoru, domu]

Skip to content

Commit

Permalink
Reverts "[ci] Temporarily allow-warnings in podspec_check_command.dart (
Browse files Browse the repository at this point in the history
#6416)" (#6419)

Reverts: #6416
Initiated by: ditman
Reason for reverting: Failures happen (later) in other plugins (more updates in the related issue)

flutter/flutter#145866
Original PR Author: ditman

Reviewed By: {jmagman}

This change reverts the following previous change:
Adds `--allow-warnings` to podspec_check_command.dart so stuff can keep rolling.

**To be removed soon!**
  • Loading branch information
auto-submit[bot] committed Mar 28, 2024
1 parent e234425 commit 924c7e6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion script/tool/lib/src/podspec_check_command.dart
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ class PodspecCheckCommand extends PackageLoopingCommand {
podspecPath,
'--configuration=Debug', // Release targets unsupported arm64 simulators. Use Debug to only build against targeted x86_64 simulator devices.
'--skip-tests',
'--allow-warnings',
'--use-modular-headers', // Flutter sets use_modular_headers! in its templates.
if (libraryLint) '--use-libraries'
];
Expand Down
4 changes: 0 additions & 4 deletions script/tool/test/podspec_check_command_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ void main() {
.path,
'--configuration=Debug',
'--skip-tests',
'--allow-warnings',
'--use-modular-headers',
'--use-libraries'
],
Expand All @@ -172,7 +171,6 @@ void main() {
.path,
'--configuration=Debug',
'--skip-tests',
'--allow-warnings',
'--use-modular-headers',
],
packagesDir.path),
Expand Down Expand Up @@ -214,7 +212,6 @@ void main() {
.path,
'--configuration=Debug',
'--skip-tests',
'--allow-warnings',
'--use-modular-headers',
'--use-libraries'
],
Expand All @@ -230,7 +227,6 @@ void main() {
.path,
'--configuration=Debug',
'--skip-tests',
'--allow-warnings',
'--use-modular-headers',
],
packagesDir.path),
Expand Down

0 comments on commit 924c7e6

Please sign in to comment.