-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Temporarily allow-warnings in podspec_check_command.dart #6416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `--allow-warnings` to podspec_check_command.dart so stuff can keep rolling. To be removed soon!
This comment was marked as resolved.
This comment was marked as resolved.
jmagman
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup ticket created here: |
Waiting to see the result of Mac_x64 check_podspecs, then applying |
Reason for revert: Failures happen (later) in other plugins (more updates in the related issue) |
11 tasks
auto-submit bot
added a commit
that referenced
this pull request
Mar 28, 2024
#6416)" (#6419) Reverts: #6416 Initiated by: ditman Reason for reverting: Failures happen (later) in other plugins (more updates in the related issue) flutter/flutter#145866 Original PR Author: ditman Reviewed By: {jmagman} This change reverts the following previous change: Adds `--allow-warnings` to podspec_check_command.dart so stuff can keep rolling. **To be removed soon!**
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 28, 2024
flutter/packages@e6b3e11...924c7e6 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Temporarily allow-warnings in podspec_check_command.dart (#6416)" (flutter/packages#6419) 2024-03-28 ditman@gmail.com [ci] Temporarily allow-warnings in podspec_check_command.dart (flutter/packages#6416) 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (#6060)" (flutter/packages#6417) 2024-03-27 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (flutter/packages#6060) 2024-03-27 43054281+camsim99@users.noreply.github.com [camerax] Use `AspectRatioStrategy` to help automatic selection of expected resolution (flutter/packages#6357) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
philipfranchi
pushed a commit
to philipfranchi/flutter-relabel-widgets
that referenced
this pull request
Mar 28, 2024
…r#145915) flutter/packages@e6b3e11...924c7e6 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Temporarily allow-warnings in podspec_check_command.dart (flutter#6416)" (flutter/packages#6419) 2024-03-28 ditman@gmail.com [ci] Temporarily allow-warnings in podspec_check_command.dart (flutter/packages#6416) 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (flutter#6060)" (flutter/packages#6417) 2024-03-27 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (flutter/packages#6060) 2024-03-27 43054281+camsim99@users.noreply.github.com [camerax] Use `AspectRatioStrategy` to help automatic selection of expected resolution (flutter/packages#6357) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…r#6416) Adds `--allow-warnings` to podspec_check_command.dart so stuff can keep rolling. **To be removed soon!**
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
flutter#6416)" (flutter#6419) Reverts: flutter#6416 Initiated by: ditman Reason for reverting: Failures happen (later) in other plugins (more updates in the related issue) flutter/flutter#145866 Original PR Author: ditman Reviewed By: {jmagman} This change reverts the following previous change: Adds `--allow-warnings` to podspec_check_command.dart so stuff can keep rolling. **To be removed soon!**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--allow-warnings
to podspec_check_command.dart so stuff can keep rolling.To be removed soon!
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.