-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Comparing changes
Open a pull request
base repository: flutter/packages
base: 129e08c
head repository: flutter/packages
compare: e4cbf23
- 11 commits
- 30 files changed
- 6 contributors
Commits on Jan 19, 2024
-
Manual roll Flutter (stable) from ef1af02aead6 to 67457e669f79 (1 rev…
…ision) (#5932) Manual roll requested by dit@google.com flutter/flutter@ef1af02...67457e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-stable-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter (stable): https://github.com/flutter/flutter/issues/new/choose To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 1371491 - Browse repository at this point
Copy the full SHA 1371491View commit details -
Bump actions/upload-artifact from 4.1.0 to 4.2.0 (#5937)
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.1.0 to 4.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p> <blockquote> <h2>v4.2.0</h2> <h2>What's Changed</h2> <ul> <li>Ability to overwrite an Artifact by <a href="https://github.com/robherley"><code>@�robherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/501">actions/upload-artifact#501</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4...v4.2.0">https://github.com/actions/upload-artifact/compare/v4...v4.2.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/upload-artifact/commit/694cdabd8bdb0f10b2cea11669e1bf5453eed0a6"><code>694cdab</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/501">#501</a> from actions/robherley/overwrite-artifact</li> <li><a href="https://github.com/actions/upload-artifact/commit/05d4fe67025ed6d5b746e3502573715a2c37e318"><code>05d4fe6</code></a> run licensed against version that matches ci</li> <li><a href="https://github.com/actions/upload-artifact/commit/40b305282182ab3d3265c0c45fd82dee1e605ace"><code>40b3052</code></a> update readme</li> <li><a href="https://github.com/actions/upload-artifact/commit/49552fcb82fc92c668b492a7d36fc7860a20c81d"><code>49552fc</code></a> add overwrite tests to workflow</li> <li><a href="https://github.com/actions/upload-artifact/commit/79615904cc1dfafb77b85c0d3a21f89dba2a38c2"><code>7961590</code></a> licensed cache</li> <li><a href="https://github.com/actions/upload-artifact/commit/11ff42c7b1b52130283d8a02bc960d1e1de95000"><code>11ff42c</code></a> add new overwrite input & docs</li> <li>See full diff in <a href="https://github.com/actions/upload-artifact/compare/1eb3cb2b3e0f29609092a73eb033bb759a334595...694cdabd8bdb0f10b2cea11669e1bf5453eed0a6">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.1.0&new-version=4.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Configuration menu - View commit details
-
Copy full SHA for da6d872 - Browse repository at this point
Copy the full SHA da6d872View commit details -
Expose registered widget libraries and local widget library widgets. (#…
…5936) This exposes the necessary information to allow rfwpg to display registered libraries and widgets in a list or tree.
Configuration menu - View commit details
-
Copy full SHA for 7901015 - Browse repository at this point
Copy the full SHA 7901015View commit details -
Manual roll Flutter from f77f82435a97 to 684247a3c78a (39 revisions) (#…
…5948) Manual roll Flutter from f77f82435a97 to 684247a3c78a (39 revisions) Manual roll requested by dit@google.com flutter/flutter@f77f824...684247a 2024-01-19 reidbaker@google.com Use Integer instead of int in map in flutter.groovy (flutter/flutter#141895) 2024-01-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from c953c83112ba to f2b441a26416 (4 revisions) (flutter/flutter#141894) 2024-01-19 dacoharkes@google.com Native assets: package in framework on iOS and MacOS (flutter/flutter#140907) 2024-01-19 ian@hixie.ch Revert "Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (#140101)" (flutter/flutter#141814) 2024-01-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 538975f2511b to c953c83112ba (3 revisions) (flutter/flutter#141886) 2024-01-19 36861262+QuncCccccc@users.noreply.github.com Add `showDragHandle` to `showBottomSheet` (flutter/flutter#141754) 2024-01-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9a6c64de8a46 to 538975f2511b (8 revisions) (flutter/flutter#141881) 2024-01-19 goderbauer@google.com Make pumpWidget's arguments named (flutter/flutter#141728) 2024-01-19 5236035+fzyzcjy@users.noreply.github.com Tiny fix inaccurate documentations about bindings (flutter/flutter#140282) 2024-01-19 zanderso@users.noreply.github.com Roll engine to 9a6c64de8a4694cef59a338cd33ac1a9e7d23d9d (flutter/flutter#141870) 2024-01-19 engine-flutter-autoroll@skia.org Roll Packages from 83c2c4d to 129e08c (13 revisions) (flutter/flutter#141865) 2024-01-19 godofredoc@google.com Add mac_x64_ios configuration. (flutter/flutter#141828) 2024-01-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 90be25d8aac3 to d1afda52d254 (1 revision) (flutter/flutter#141825) 2024-01-19 ian@hixie.ch Move the requestKeyboard up to the widgets layer (flutter/flutter#141655) 2024-01-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from dde3ebf6551a to 90be25d8aac3 (1 revision) (flutter/flutter#141817) 2024-01-18 yjbanov@google.com enable more tests in web mode (flutter/flutter#141791) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9dded186bcff to dde3ebf6551a (2 revisions) (flutter/flutter#141811) 2024-01-18 davidmartos96@gmail.com Update margin between label and icon in Tab to better reflect Material specs (flutter/flutter#140698) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3106e08e1219 to 9dded186bcff (2 revisions) (flutter/flutter#141807) 2024-01-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enable native compilation for windows-arm64 " (flutter/flutter#141809) 2024-01-18 godofredoc@google.com Run framework_tests_misc in arm64 and x64. (flutter/flutter#141797) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from f4a4f046b173 to 3106e08e1219 (1 revision) (flutter/flutter#141802) 2024-01-18 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.2.0 (flutter/flutter#141803) 2024-01-18 goderbauer@google.com Update labeler.yml (flutter/flutter#141697) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 75400c49fa0b to f4a4f046b173 (2 revisions) (flutter/flutter#141800) 2024-01-18 polinach@google.com Reland "Remove hack from PageView." (flutter/flutter#141533) 2024-01-18 smartercallum@gmail.com ScaleGestureRecognizer pointerCount=2 for trackpad gestures (flutter/flutter#140745) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from de68e7612948 to 75400c49fa0b (2 revisions) (flutter/flutter#141796) 2024-01-18 15619084+vashworth@users.noreply.github.com Run `flutter_gallery_ios__start_up` test on Mac-14 in staging (flutter/flutter#141795) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from d80fe1cb5854 to de68e7612948 (1 revision) (flutter/flutter#141789) 2024-01-18 101587250+pbo-linaro@users.noreply.github.com Enable native compilation for windows-arm64 (flutter/flutter#137618) 2024-01-18 xilaizhang@google.com [github actions] Fix token issue on actions/checkout package (flutter/flutter#141652) 2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from b75d6d80d813 to d80fe1cb5854 (2 revisions) (flutter/flutter#141785) 2024-01-18 jesus_sguerrero@hotmail.com Revert "Native assets: roll deps" (flutter/flutter#141748) 2024-01-18 6655696+guidezpl@users.noreply.github.com Deprecate M2 curves (flutter/flutter#134417) 2024-01-18 rmolivares@renzo-olivares.dev Fix: TextField can inherit `errorStyle` from `InputDecorationTheme`. (flutter/flutter#141227) 2024-01-18 109111084+yaakovschectman@users.noreply.github.com Add check for Bank of Brazil security module to Windows Flutter Doctor validators (flutter/flutter#141135) 2024-01-18 reidbaker@google.com Fix gradle lints No semantic change should be present. (flutter/flutter#141692) 2024-01-18 engine-flutter-autoroll@skia.org Roll Packages from 1a2b780 to 83c2c4d (5 revisions) (flutter/flutter#141778) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human ...
Configuration menu - View commit details
-
Copy full SHA for bb9be73 - Browse repository at this point
Copy the full SHA bb9be73View commit details -
[ci] Run Swift formatter and linter during CI formatting (#5928)
Make `swift-format` CIPD package available on the `PATH` https://flutter-review.googlesource.com/c/recipes/+/54020 Run `format --no-clang-format --no-java --no-kotlin --no-dart` on the macOS builder so it doesn't duplicate same `format` call run on Linux. Filter out generated files until flutter/flutter#141799 is done. Also add `swift-format lint` call during `format` command. Fix the one casing issue it found in a test file. Failing run: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8758535881172004177/+/u/Run_package_tests/Swift_format/stdout Successful run: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8758492350529121249/+/u/Run_package_tests/Swift_format/stdout Fixes flutter/flutter#41129
Configuration menu - View commit details
-
Copy full SHA for 44ee590 - Browse repository at this point
Copy the full SHA 44ee590View commit details
Commits on Jan 20, 2024
-
[camera]fix a sample buffer memory leak on pause resume recording (#5927
) This memory leak happens when pause/resume the recording. Depending on camera resolution, about 1-2MB leaks for every resume, so it can add up pretty fast if we frequently pause/resume. We only reference this sample buffer inside the scope of this method (e.g. directly piping into file IO), so no need to retain it again, as it's already retained and will be released afterwards by apple. (We did keep around the pixel buffer, but we already manually [retain](https://github.com/flutter/packages/blob/d7ee75ad59ad7bc45e659d0599e935e9e7981ea1/packages/camera/camera_avfoundation/ios/Classes/FLTCam.m#L403) and [release](https://github.com/flutter/packages/blob/d7ee75ad59ad7bc45e659d0599e935e9e7981ea1/packages/camera/camera_avfoundation/ios/Classes/FLTCam.m#L415) that) Bug was introduced in flutter/plugins#1370. *List which issues are fixed by this PR. You must list at least one issue.* flutter/flutter#132013 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Configuration menu - View commit details
-
Copy full SHA for 7b07d18 - Browse repository at this point
Copy the full SHA 7b07d18View commit details -
Roll Flutter from 684247a3c78a to ddf60fb08733 (12 revisions) (#5949)
flutter/flutter@684247a...ddf60fb 2024-01-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1385f76018ab to 704ef3399012 (1 revision) (flutter/flutter#141932) 2024-01-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f6649bdfef2 to 1385f76018ab (1 revision) (flutter/flutter#141926) 2024-01-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4d67f267b115 to 6f6649bdfef2 (1 revision) (flutter/flutter#141920) 2024-01-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 53a2436cf75c to 4d67f267b115 (1 revision) (flutter/flutter#141917) 2024-01-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from a9b87c6288d2 to 53a2436cf75c (1 revision) (flutter/flutter#141916) 2024-01-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from d00e55f7f8ed to a9b87c6288d2 (3 revisions) (flutter/flutter#141914) 2024-01-20 31859944+LongCatIsLooong@users.noreply.github.com Remove more textScaleFactor references (flutter/flutter#141816) 2024-01-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 517fc2bbfa51 to d00e55f7f8ed (1 revision) (flutter/flutter#141909) 2024-01-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from f2b441a26416 to 517fc2bbfa51 (2 revisions) (flutter/flutter#141904) 2024-01-19 tessertaha@gmail.com Fix "Delete" tooltip is shown disabled on chips with `onDeleted` callback (flutter/flutter#141770) 2024-01-19 godofredoc@google.com Run module_test_ios on arm and x64 (flutter/flutter#141815) 2024-01-19 36861262+QuncCccccc@users.noreply.github.com `SearchAnchor` search view clear button only shows up when text input is not empty (flutter/flutter#141755) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 648315f - Browse repository at this point
Copy the full SHA 648315fView commit details -
[pigeon] Improve style of generated Swift code (#5938)
Cleans up our Swift output to be more idiomatic (or in a couple of cases to match swift-format` in particular): - Don't indent `case`s in `switch`es. - Remove some stray `;`s - Remove `()`s around `if` conditions - Add trailing newlines in multi-element arrays - Fix some missing standard whitespace in a handful of places where it was missing (after named arguments, between `()` and `{`) - Indent inside `#if` constructs. - Two changes that are more arguable, as it's not clear that they are non-idiomatic vs just non-`swift-format`-style (and they add branching to the generator that would otherwise not be needed): - Don't put a trailing comma on the list element of a one-element list - Don't put `()` on zero-arg method calls with a trailing closure With these changes, as far as can tell the diffs created by `swift-format` are just line wrapping. Fixes flutter/flutter#141799
Configuration menu - View commit details
-
Copy full SHA for 2b0d290 - Browse repository at this point
Copy the full SHA 2b0d290View commit details -
[pigeon] Support other hosts in generated file CI checks (#5944)
Reworks Pigeon's CI validation of generated files to support multiple hosts, rather than only Linux, with the ability to set specific languages per host, to allow us to run validation for each language on whatever host it is most convenient to set up a formatter for that language, rather than having to support all languages on Linux. See discussion in #5928 Part of flutter/flutter#41129
Configuration menu - View commit details
-
Copy full SHA for 2bb7d14 - Browse repository at this point
Copy the full SHA 2bb7d14View commit details
Commits on Jan 21, 2024
-
Update platform label rules for shared iOS/macOS (#5801)
Update automatic platform label rules for more implementations that are shared between iOS and macOS.
Configuration menu - View commit details
-
Copy full SHA for 906909b - Browse repository at this point
Copy the full SHA 906909bView commit details -
Roll Flutter from ddf60fb08733 to 5dea6b994e8f (5 revisions) (#5951)
flutter/flutter@ddf60fb...5dea6b9 2024-01-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2b31ad2fb819 to a7b207d5a1fe (1 revision) (flutter/flutter#141945) 2024-01-21 christopherfujino@gmail.com [flutter_tools] update analyze_once_test.dart to be null-safe (flutter/flutter#141790) 2024-01-21 linxunfeng@yeah.net Adjust the position of require File.expand_path (flutter/flutter#141521) 2024-01-21 yjbanov@google.com Add RadioListItem use-case to a11y_assessments (flutter/flutter#140984) 2024-01-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 704ef3399012 to 2b31ad2fb819 (1 revision) (flutter/flutter#141937) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for e4cbf23 - Browse repository at this point
Copy the full SHA e4cbf23View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 129e08c...e4cbf23