This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Enable Firebase Test Lab testing of package_info package #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digiter
reviewed
Sep 9, 2019
| RUN sudo apt-get update && sudo apt-get install -y google-cloud-sdk && \ | ||
| gcloud config set core/disable_usage_reporting true && \ | ||
| gcloud config set component_manager/disable_update_check true | ||
|
|
There was a problem hiding this comment.
In general, fewer RUNs could reduce Docker image size.
There was a problem hiding this comment.
Fair point, I combined a couple of the run commands.
If we really wanted to be efficient we'd probably be building the Docker image and putting it in the cloud like the flutter/flutter repo does: https://github.com/flutter/flutter/blob/master/.cirrus.yml#L2
Not sure how much of a priority that is though.
This was referenced Sep 9, 2019
|
A more updated version of the migrated plugin is in #2160. I'm closing this PR in favor of that one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test updates the package_info package to use the instrumentation_adapter plugin for Android testing.
Also changed the Cirrus configuration to upload the test to Firebase Test Lab.
TODOs: