-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Enable Firebase Test Lab testing of package_info package #2025
Conversation
RUN sudo apt-get update && sudo apt-get install -y google-cloud-sdk && \ | ||
gcloud config set core/disable_usage_reporting true && \ | ||
gcloud config set component_manager/disable_update_check true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, fewer RUNs could reduce Docker image size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point, I combined a couple of the run commands.
If we really wanted to be efficient we'd probably be building the Docker image and putting it in the cloud like the flutter/flutter repo does: https://github.com/flutter/flutter/blob/master/.cirrus.yml#L2
Not sure how much of a priority that is though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A more updated version of the migrated plugin is in #2160. I'm closing this PR in favor of that one. |
This test updates the package_info package to use the instrumentation_adapter plugin for Android testing.
Also changed the Cirrus configuration to upload the test to Firebase Test Lab.
TODOs: