This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[instrumentation_adapter] Add stub iOS implementation and example app #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digiter
approved these changes
Sep 9, 2019
| super.onCreate(savedInstanceState) | ||
| GeneratedPluginRegistrant.registerWith(this) | ||
| } | ||
| } |
There was a problem hiding this comment.
Do you intent to mix the use of java and kotlin? I'm fine with either way, but usually keeping it consistent is better to reduce confusion or dependency issues.
There was a problem hiding this comment.
hmm, I'll guess I'll switch it to the Java version. Flutter create is defaulting to Kotlin but most of the plugins repo is still Java.
noelmansour
pushed a commit
to snowble/plugins
that referenced
this pull request
Nov 13, 2019
…flutter#2052) * Add stub iOS implementation and example app * Gracefully handle running tests on the host
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
…flutter#2052) * Add stub iOS implementation and example app * Gracefully handle running tests on the host
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
…flutter#2052) * Add stub iOS implementation and example app * Gracefully handle running tests on the host
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple example app.
Fixes iOS runtime failures when running instrumentation adapter tests using Flutter driver.
Required for landing #2025