[image_picker] Update NSPhotoLibraryUsageDescription description in README #6589
Conversation
| @@ -23,7 +23,6 @@ As a result of implementing PHPicker it becomes impossible to pick HEIC images o | |||
| Add the following keys to your _Info.plist_ file, located in `<project root>/ios/Runner/Info.plist`: | |||
|
|
|||
| * `NSPhotoLibraryUsageDescription` - describe why your app needs permission for the photo library. This is called _Privacy - Photo Library Usage Description_ in the visual editor. | |||
| * This permission is not required for image picking on iOS 11+ if you pass `false` for `requestFullMetadata`. | |||
There was a problem hiding this comment.
LGTM if you want to remove it fully, but maybe instead we should leave it but change to something like "This permission will not be requested if you always pass false for requestFullMetadata, but App Store policy requires including the plist entry."
That way people (including future us, potentially) won't think it's a mistake that we're listing it here when they read the code documentation that talks about how that flag interacts with permissions.
|
Did you want to land this as is, or update it per the comment? |
I need to update, haven't gotten around to it though. |
|
@jmagman FYI I'm planning on doing the repo merge in the next 1-2 weeks, so if you can find time to update the PRs you have open here it'll save you some PR migration work. |
|
I'm going to merge this before the repo migration happens. @vashworth we can revisit this wording when you look into the metadata default behavior. |
* 3c7d54bba [camerax] Implement camera preview (flutter/plugins#7112) * 48f50b4f1 [image_picker] Update NSPhotoLibraryUsageDescription description in README (flutter/plugins#6589) * eea17c996 Migrate these tests to the "new" API. (flutter/plugins#7189) * 190c6d916 Roll Flutter from 298d8c7 to 0be7c3f (21 revisions) (flutter/plugins#7194) * c0d4e8041 [google_sign_in] Endorses next web package. (flutter/plugins#7191) * cc4eaba0f [google_maps]: Bump org.mockito:mockito-core (flutter/plugins#7099) * 717a8bfef [image_picker]: Bump org.mockito:mockito-core (flutter/plugins#7097) * 8a09d8c13 [lifecycle]: Bump org.mockito:mockito-core (flutter/plugins#7096) * 40377a12a [in_app_pur]: Bump org.mockito:mockito-core (flutter/plugins#7094) * 6a4bbf1df [url_launcher]: Bump org.mockito:mockito-core (flutter/plugins#7098) * 96ab5cd12 Update codeowners (flutter/plugins#7188) * 00d5855cc Add missing CODEOWNER (flutter/plugins#7016) * c3e9d1ba3 [webview_flutter] Adds examples of accessing platform-specific features for each class (flutter/plugins#7089) * 1f7b57917 Roll Flutter from 0be7c3f to 33e4d21 (5 revisions) (flutter/plugins#7196) * 1acaf55c2 [plugins] Disables the AndroidGradlePluginVersion issue ID in all android packages (flutter/plugins#7045) * 132d9c77d [espresso] Update some dependencies (flutter/plugins#7195)
Fixes flutter/flutter#113603
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.