[go: nahoru, domu]

Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

dependabot[bot]
Copy link
Contributor
@dependabot dependabot bot commented on behalf of github Feb 3, 2023

Bumps org.mockito:mockito-core from 4.8.0 to 5.1.1.

Release notes

Sourced from org.mockito:mockito-core's releases.

v5.1.1

Changelog generated by Shipkit Changelog Gradle Plugin

5.1.1

v5.1.0

Changelog generated by Shipkit Changelog Gradle Plugin

5.1.0

v5.0.0

Mockito 5: prepare for future JDK versions

For a while now, we have seen an increase in problems/incompatibilities with recent versions of the JDK due to our usage of JVM-internal API. Most notably, JDK 17 made some changes which are incompatible with the current subclass mockmaker. Therefore, to prepare for the future of JDK, we are making some core changes to ensure Mockito keeps on working.

Switch the default mockmaker to mockito-inline

Back in Mockito 2.7.6, we published a new mockmaker based on the "inline bytecode" principle. This mockmaker creates mocks manipulating bytecode equivalent within the original class such that its method implementations hook into the normal Mockito machinery. As a comparison, the subclass mockmaker generates "real" subclasses for mocks, to mimic the same behavior. While the approaches are similar, the inline mockmaker avoids certain restrictions that the JDK imposes. For example, it does not violate module boundaries (introduced in JDK 9, but more heavily used in JDK 17) and avoids the leaking of the creation of the subclass.

Massive thanks to community member @​reta who implemented this change.

Note: this does not affect mockito-android nor testing on Android.

When should I still be using the subclass mockmaker?

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from GaryQian as a code owner February 3, 2023 22:36
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Feb 3, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 19, 2023
@dependabot dependabot bot force-pushed the dependabot/gradle/packages/url_launcher/url_launcher_android/android/org.mockito-mockito-core-5.1.1 branch from 634f092 to 066245e Compare February 19, 2023 14:32
@auto-submit
Copy link
auto-submit bot commented Feb 19, 2023

auto label is removed for flutter/plugins, pr: 7098, due to - This commit has no checks. Please check that ci.yaml validation has started and there are multiple checks. If not, try uploading an empty commit.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 19, 2023
@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 19, 2023
Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 4.8.0 to 5.1.1.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v4.8.0...v5.1.1)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/packages/url_launcher/url_launcher_android/android/org.mockito-mockito-core-5.1.1 branch from 066245e to 9dfa589 Compare February 19, 2023 14:56
@auto-submit auto-submit bot merged commit 6a4bbf1 into main Feb 19, 2023
@dependabot dependabot bot deleted the dependabot/gradle/packages/url_launcher/url_launcher_android/android/org.mockito-mockito-core-5.1.1 branch February 19, 2023 15:15
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 20, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 20, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 20, 2023
* 3c7d54bba [camerax] Implement camera preview (flutter/plugins#7112)

* 48f50b4f1 [image_picker] Update NSPhotoLibraryUsageDescription description in README (flutter/plugins#6589)

* eea17c996 Migrate these tests to the "new" API. (flutter/plugins#7189)

* 190c6d916 Roll Flutter from 298d8c7 to 0be7c3f (21 revisions) (flutter/plugins#7194)

* c0d4e8041 [google_sign_in] Endorses next web package. (flutter/plugins#7191)

* cc4eaba0f [google_maps]: Bump org.mockito:mockito-core (flutter/plugins#7099)

* 717a8bfef [image_picker]: Bump org.mockito:mockito-core (flutter/plugins#7097)

* 8a09d8c13 [lifecycle]: Bump org.mockito:mockito-core (flutter/plugins#7096)

* 40377a12a [in_app_pur]: Bump org.mockito:mockito-core (flutter/plugins#7094)

* 6a4bbf1df [url_launcher]: Bump org.mockito:mockito-core (flutter/plugins#7098)

* 96ab5cd12 Update codeowners (flutter/plugins#7188)

* 00d5855cc Add missing CODEOWNER (flutter/plugins#7016)

* c3e9d1ba3 [webview_flutter] Adds examples of accessing platform-specific features for each class (flutter/plugins#7089)

* 1f7b57917 Roll Flutter from 0be7c3f to 33e4d21 (5 revisions) (flutter/plugins#7196)

* 1acaf55c2 [plugins] Disables the AndroidGradlePluginVersion issue ID in all android packages (flutter/plugins#7045)

* 132d9c77d [espresso] Update some dependencies (flutter/plugins#7195)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App dependencies Pull requests that update a dependency file java Pull requests that update Java code needs tests p: url_launcher platform-android
Projects
None yet
2 participants