[google_maps_flutter] Modified README.md to fix minor syntax issues
#6631
Conversation
There was a problem hiding this comment.
Thanks for the contribution!
Any changes to code in READMEs needs to use code excerpts, so this will need to be converted as described in that documentation as part of changing it.
|
Thank you @stuartmorgan! I have added the code excerpts to the README. |
|
The excerpt process is failing in CI; it looks like you didn't set a I'm going to mark this as a draft, since it's not passing CI; please feel free to mark it for review again once it's passing. Note that as part of fixing CI you'll need to do several steps that you checked off in the checklist but didn't actually do:
Please also do this as well:
(In the future, please follow the checklist, rather than just checking items in it; it's part of the template for a reason.) |
README.md to fix minor syntax issuesREADME.md to fix minor syntax issues
|
@stuartmorgan I have fixed all the issues. |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@stuartmorgan I have made the change, but only one test fails. |
|
@tarrinneal or @ditman could you do the secondary review on this README conversion to excerpts? |
There was a problem hiding this comment.
Looks solid to me, it's cool to see the excerpts rules catching issues with the readme code ( with the help of @DEVSOG12 of course).
* 13818023c [camera] Attempt to fix flaky new Android test (flutter/plugins#6831) * da4321d01 [google_maps_flutter] Modified `README.md` to fix minor syntax issues (flutter/plugins#6631) * e8c9731f1 Roll Flutter from eefbe85 to bd0791b (25 revisions) (flutter/plugins#6832) * 2eb616545 Reland "[google_maps_flutter] ios: re-enable test with popup #5312" (flutter/plugins#6783) * 738bd91d8 Update FlutterFire link (flutter/plugins#6835) * ec2041f82 Roll Flutter from bd0791b to 15af817 (27 revisions) (flutter/plugins#6837)
…#116996) * 13818023c [camera] Attempt to fix flaky new Android test (flutter/plugins#6831) * da4321d01 [google_maps_flutter] Modified `README.md` to fix minor syntax issues (flutter/plugins#6631) * e8c9731f1 Roll Flutter from eefbe85 to bd0791b (25 revisions) (flutter/plugins#6832) * 2eb616545 Reland "[google_maps_flutter] ios: re-enable test with popup flutter#5312" (flutter/plugins#6783) * 738bd91d8 Update FlutterFire link (flutter/plugins#6835) * ec2041f82 Roll Flutter from bd0791b to 15af817 (27 revisions) (flutter/plugins#6837)
…flutter#6631) * Refactored Reaadme using code excerpts * Fixes * Updated Upstream and Fixed Test Errors * Re-added temp_exclude_excerpt.yaml back due to Failing Test * Restore deleted changelog entries Co-authored-by: stuartmorgan <stuartmorgan@google.com>
I fixed minor code style issue in the example. e.g. change
finaltoconstbecausefinalwasn't neccessary in the case.README.mdPre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.