-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[camera][google_maps_flutter][path_provider] prepare for TestDefaultBinaryMessengerBinding.instance becoming non-nullable #6847
[camera][google_maps_flutter][path_provider] prepare for TestDefaultBinaryMessengerBinding.instance becoming non-nullable #6847
Conversation
// This should be removed once the relevant changes makes it to stable. | ||
// TODO(ianh): look into this in Q2 2023. | ||
T _ambiguate<T extends Object>(T? value) { | ||
return value!; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional that this is the reverse of what we did last time? We did T
->T?
and then kept the !
at the call site before, which seems more explicit about what's happening at the call site. If we want this behavior instead I think we should call this something that sounds dangerous, since it's force-unwrapping (e.g., _forceUnwrapIfNullable
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hixie Ping on this question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, definitely not intentional. i'll reverse it.
82876ba
to
2787cf0
Compare
2787cf0
to
622d354
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* 8f83dc29b [various] Standardize the extension for Pigeon-generated Dart (flutter/plugins#7029) * 8fcff8756 Roll Flutter from 75680ae to 0a22a1d (3 revisions) (flutter/plugins#7051) * 3d81a0071 [tool] More main-branch detection improvement (flutter/plugins#7067) * e41f9f95e [ci] Clean up analysis options (flutter/plugins#7068) * 4cf6f4494 [in_app_puchase_storekit] handle `appStoreReceiptURL` is nil (flutter/plugins#7069) * d5bab1668 prepare for TestDefaultBinaryMessengerBinding.instance becoming non-nullable (flutter/plugins#6847) * 36d8066cf Roll Flutter from 0a22a1d to d278808 (58 revisions) (flutter/plugins#7078) * ec463866f [various] prepare for more const widgets (flutter/plugins#7074) * dbf8d8d07 Change google_sign_in_ios and image_picker_ios owners (flutter/plugins#7070) * 1d4570bb0 Update README.md (flutter/plugins#7076) * 9302d87ee [ci] More cirrus.yml pre-alignment with flutter/packages (flutter/plugins#7079)
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).