This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[ci] Clean up analysis options #7068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes some options that are no longer necessary, further aligning the options with flutter/packages. Part of flutter/flutter#113764
stuartmorgan
commented
Jan 31, 2023
| # This file is a copy of analysis_options.yaml from flutter repo | ||
| # as of 2022-07-27, but with some modifications marked with | ||
| # "DIFFERENT FROM FLUTTER/FLUTTER" below. The file is expected to | ||
| # be kept in sync with the master file from the flutter repo. |
There was a problem hiding this comment.
Everything from here up is just comment differences from flutter/packages; aligning them help reduce noise in my diffs as I'm finishing the pre-merge alignment.
| # treat missing returns as a warning (not a hint) | ||
| missing_return: warning | ||
| # allow having TODO comments in the code | ||
| todo: ignore |
There was a problem hiding this comment.
See flutter/flutter#108747 where these were removed from flutter/flutter (where we got them originally).
| # Ignore analyzer hints for updating pubspecs when using Future or | ||
| # Stream and not importing dart:async | ||
| # Please see https://github.com/flutter/flutter/pull/24528 for details. | ||
| sdk_version_async_exported_from_core: ignore |
There was a problem hiding this comment.
No longer necessary.
| # Turned off until null-safe rollout is complete. | ||
| unnecessary_null_comparison: ignore | ||
| ### Local flutter/plugins changes ### | ||
| # Allow null checks for as long as mixed mode is officially supported. | ||
| always_require_non_null_named_parameters: false # not needed with nnbd |
There was a problem hiding this comment.
Only applies to pre-NNBD code, which we don't have any of.
| # Allow null checks for as long as mixed mode is officially supported. | ||
| always_require_non_null_named_parameters: false # not needed with nnbd | ||
| exclude: | ||
| exclude: # DIFFERENT FROM FLUTTER/FLUTTER |
There was a problem hiding this comment.
flutter/packages (correctly) has this annotation, so adding it to match.
tarrinneal
approved these changes
Jan 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 2, 2023
* 8f83dc29b [various] Standardize the extension for Pigeon-generated Dart (flutter/plugins#7029) * 8fcff8756 Roll Flutter from 75680ae to 0a22a1d (3 revisions) (flutter/plugins#7051) * 3d81a0071 [tool] More main-branch detection improvement (flutter/plugins#7067) * e41f9f95e [ci] Clean up analysis options (flutter/plugins#7068) * 4cf6f4494 [in_app_puchase_storekit] handle `appStoreReceiptURL` is nil (flutter/plugins#7069) * d5bab1668 prepare for TestDefaultBinaryMessengerBinding.instance becoming non-nullable (flutter/plugins#6847) * 36d8066cf Roll Flutter from 0a22a1d to d278808 (58 revisions) (flutter/plugins#7078) * ec463866f [various] prepare for more const widgets (flutter/plugins#7074) * dbf8d8d07 Change google_sign_in_ios and image_picker_ios owners (flutter/plugins#7070) * 1d4570bb0 Update README.md (flutter/plugins#7076) * 9302d87ee [ci] More cirrus.yml pre-alignment with flutter/packages (flutter/plugins#7079)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some options that are no longer necessary, further aligning the options with flutter/packages.
This is (at least for now) the last of the diffs that need to be changed on this side; the handful of remaining diffs will be address in flutter/packages.
Part of flutter/flutter#113764