-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[in_app_purchase] Update minimum Flutter version to 3.3 and iOS 11 #6873
Conversation
07cffb1
to
4f941a4
Compare
@@ -21,6 +21,6 @@ | |||
<key>CFBundleVersion</key> | |||
<string>1.0</string> | |||
<key>MinimumOSVersion</key> | |||
<string>8.0</string> | |||
<string>11.0</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in packages/in_app_purchase/in_app_purchase/example/
and the Xcode project files/Podfile were automatically applied by the Flutter tool.
NSLocale *system = [[NSLocale alloc] initWithLocaleIdentifier:@"en_US"]; | ||
NSDictionary *map = [FIAObjectTranslator getMapFromNSLocale:system]; | ||
XCTAssertEqualObjects(map[@"currencySymbol"], system.currencySymbol); | ||
XCTAssertEqualObjects(map[@"countryCode"], system.countryCode); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited this manually, removing the @available
check.
@@ -20,7 +20,7 @@ Downloaded by pub (not CocoaPods). | |||
s.public_header_files = 'Classes/**/*.h' | |||
s.ios.dependency 'Flutter' | |||
s.osx.dependency 'FlutterMacOS' | |||
s.ios.deployment_target = '9.0' | |||
s.ios.deployment_target = '11.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also edited this manually.
4f941a4
to
0d70fcd
Compare
@@ -1,3 +1,7 @@ | |||
## 0.3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stuartmorgan I bumped the iOS federated version by a minor version for the iOS minimum change, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable. There's a lot of grey area in minor vs bugfix.
@@ -1,3 +1,7 @@ | |||
## NEXT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do a version bump and README update here, as with ios_platform_images.
(It's arguable in the federated world what "supported version" actually means, since technically you could use 3.1.1 or whatever with iOS 9 and an older version of Flutter and the resolver would just give you an older version of the implementation package, but I think having the current implementation's version in the main package is the least confusing.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, not sure how I missed this chart in the README:
| **Support** | SDK 16+ | 9.0+ | 10.15+ | |
Will add a patch bump.
@@ -2,7 +2,7 @@ name: in_app_purchase_storekit | |||
description: An implementation for the iOS and macOS platforms of the Flutter `in_app_purchase` plugin. This uses the StoreKit Framework. | |||
repository: https://github.com/flutter/plugins/tree/main/packages/in_app_purchase/in_app_purchase_storekit | |||
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+in_app_purchase%22 | |||
version: 0.3.4 | |||
version: 0.3.5 | |||
|
|||
environment: | |||
sdk: ">=2.14.0 <3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next line (I can't comment there since it's outside the context) is missing the flutter minimum update to 3.3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♀️ this was hard to keep all these package changes organized, thanks for catching. Glad I split it into reviewable-sized changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0d70fcd
to
4192d3c
Compare
* cd09d9d31 [ci] Update iOS simulator (flutter/plugins#7131) * 016c3b7f1 Roll Flutter from df41e58 to 22e17bb (28 revisions) (flutter/plugins#7186) * 7160f55e8 [ios_platform_images] Update minimum version to iOS 11 (flutter/plugins#6874) * ea048a249 [in_app_purchase] Update minimum Flutter version to 3.3 and iOS 11 (flutter/plugins#6873) * 530442456 [google_sign_in_web] Migrate to the GIS SDK. (flutter/plugins#6921) * 9a3a77e6c [image_picker] Fix images changing to incorrect orientation (flutter/plugins#7187) * 8f3419be5 Roll Flutter from 22e17bb to 298d8c7 (20 revisions) (flutter/plugins#7190)
in_app_purchase
part of flutter/flutter#101965.Built the
in_app_purchase
andin_app_purchase_ios
example projects on Flutter 3.3. and let the tool auto-migrate various Xcode project/Podfile files.Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.