[ios_platform_images] Update minimum version to iOS 11 #6874
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
|
||
| environment: | ||
| sdk: ">=2.14.0 <3.0.0" | ||
| sdk: '>=2.18.0 <3.0.0' |
There was a problem hiding this comment.
This should have been bumped with 0.2.1 when updated to 3.3.
There was a problem hiding this comment.
We don't generally bother to keep them in sync. I've thought about having tooling enforce expected pairs, but I haven't come up with any benefit from doing so.
So the current approach is that we mostly only update each one when there is a specific reason for that constraint. Usually it's just the Flutter constraint, but things like NNBD or new Dart features trigger an sdk update. Or when people feel like it, like here :)
| @@ -17,7 +17,7 @@ Downloaded by pub (not CocoaPods). | |||
| s.documentation_url = 'https://pub.dev/packages/ios_platform_images' | |||
| s.source_files = 'Classes/**/*' | |||
| s.dependency 'Flutter' | |||
| s.platform = :ios, '9.0' | |||
| s.platform = :ios, '11.0' | |||
There was a problem hiding this comment.
This was manually edited.
a5b859b
to
ecf07c3
Compare
|
|
||
| environment: | ||
| sdk: ">=2.14.0 <3.0.0" | ||
| sdk: '>=2.18.0 <3.0.0' |
There was a problem hiding this comment.
We don't generally bother to keep them in sync. I've thought about having tooling enforce expected pairs, but I haven't come up with any benefit from doing so.
So the current approach is that we mostly only update each one when there is a specific reason for that constraint. Usually it's just the Flutter constraint, but things like NNBD or new Dart features trigger an sdk update. Or when people feel like it, like here :)
| @@ -1,3 +1,7 @@ | |||
| ## 0.2.2 | |||
|
|
|||
| * Updates minimum version to iOS 11. | |||
There was a problem hiding this comment.
The README needs an update too. We haven't built out tooling to enforce that it matches reality yet (flutter/flutter#84200).
ecf07c3
to
d73ae22
Compare
* cd09d9d31 [ci] Update iOS simulator (flutter/plugins#7131) * 016c3b7f1 Roll Flutter from df41e58 to 22e17bb (28 revisions) (flutter/plugins#7186) * 7160f55e8 [ios_platform_images] Update minimum version to iOS 11 (flutter/plugins#6874) * ea048a249 [in_app_purchase] Update minimum Flutter version to 3.3 and iOS 11 (flutter/plugins#6873) * 530442456 [google_sign_in_web] Migrate to the GIS SDK. (flutter/plugins#6921) * 9a3a77e6c [image_picker] Fix images changing to incorrect orientation (flutter/plugins#7187) * 8f3419be5 Roll Flutter from 22e17bb to 298d8c7 (20 revisions) (flutter/plugins#7190)
ios_platform_imagespart of flutter/flutter#101965.Built the
ios_platform_imagesexample projects on Flutter 3.3. and let the tool auto-migrate various Xcode project/Podfile files.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.