[ci] Part 1 of swapping iOS platform test arch #7064
Conversation
Adds Intel versions of iOS build-all and ARM versions of iOS platform tests, as part one of swapping them. Once the new tasks propagate, they will be brought out of bringup mode and the old versions removed. These were on the opposite architectures because of issues with running the platfor tests on Cirrus ARM VMs, and then were ported as-is from Cirrus to LUCI, but now that macOS ARM works on LUCI we can switch to the desired configuration.
52f54c8
to
5251954
Compare
|
@jmagman I tested this by hijacking the four macOS ARM tasks that are now in this repository.
(I think I said in an earlier conversation that I had tried this and it didn't work, but realized I'd confused this with the Pigeon tests I'm having issues with hanging in CI; I'd never tried the plugin drive tests in ARM LUCI.) |
|
That's a good point, they have gotten longer since the last sharding. I'll update this to make the ARM version use 5 shards, and we'll see how that is. (There's also some potential for making the shards smarter to distribute load better, but it's never been clear if there's a way to do that that isn't really fragile to minor changes.) |
.ci.yaml
Outdated
| @@ -168,6 +188,56 @@ targets: | |||
| target_file: ios_platform_tests.yaml | |||
| package_sharding: "--shardIndex 3 --shardCount 4" | |||
|
|
|||
| - name: Mac_arm64 ios_platform_tests_1_of_5 master | |||
There was a problem hiding this comment.
Now that you've felt the pain of bringup, you may be better off leaving off the number of shards so adding a shard doesn't require a rename of all of them, like:
| - name: Mac_arm64 ios_platform_tests_1_of_5 master | |
| - name: Mac_arm64 ios_platform_tests_1 master |
There was a problem hiding this comment.
Good point. Keyong and I talked about the naming, but I don't think we talked about that specifically; I think including the number of shards was just a translation from the Cirrus behavior of the matrix variables being in the display name.
There was a problem hiding this comment.
Renamed from x_of_N to shard_x. I also added - plugins while I'm renaming everything so the flutter/packages version can have no suffix to reduce work after the merge (currently they all have - packages to avoid name collisions in the central LUCI system).
|
auto label is removed for flutter/plugins, pr: 7064, due to - The status or check suite legacy_version_analyze CHANNEL:3.3.10 DART_VERSION:2.18.6 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
The sharding setup here is intended to match flutter/plugin to prepare for merging, and it's being changed (along with the names) in flutter/plugins#7064
* 90f447313 [ci] Increase timeouts for platform_tests (flutter/plugins#7036) * f5568e4b1 [google_sign_in] Add doc for iOS auth with SERVER_CLIENT_ID (flutter/plugins#4747) * 0c05e8d91 Roll Flutter from a815ee6 to 75680ae (58 revisions) (flutter/plugins#7048) * a4c320902 [camera]: Bump camerax_version from 1.3.0-alpha02 to 1.3.0-alpha03 in /packages/camera/camera_android_camerax/android (flutter/plugins#7061) * 8f12b27b6 [ci] Add LUCI versions of macOS ARM tests (flutter/plugins#6984) * 3843b38e2 [tool] Improve main-branch detection (flutter/plugins#7038) * d39e7569c [in_app_purchase] Prep for more const widgets (flutter/plugins#7030) * ddb9777ee [ci] Switch remaining macOS host tests to LUCI (flutter/plugins#7063) * 2edf56324 [ci] Part 1 of swapping iOS platform test arch (flutter/plugins#7064) * 35f0b1a49 [camerax] Add system services to plugin (flutter/plugins#6986) * 5dd0f41a2 [webview]: Bump mockito-inline (flutter/plugins#7056) * 1896f10ca [webview_flutter_wkwebview][webview_flutter_android] Fixes bug where the `WebView`s could not be released (flutter/plugins#6996) * a494825fa [camerax] Allow instance manager to create identical objects (flutter/plugins#7034) * 6ef73da26 [ci] Increase heavy workload memory (flutter/plugins#7065) * 9da327ca3 [various] Update to use sharedDarwinSource (flutter/plugins#7027)
The sharding setup here is intended to match flutter/plugin to prepare for merging, and it's being changed (along with the names) in flutter/plugins#7064
Adds Intel versions of iOS build-all and ARM versions of iOS platform tests, as part one of swapping them. Once the new tasks propagate, they will be brought out of bringup mode and the old versions removed.
These were on the opposite architectures because of issues with running the platform tests on Cirrus ARM VMs, and then were ported as-is from Cirrus to LUCI, but now that macOS ARM works on LUCI we can switch to the desired configuration.
Also increases sharding from 4 to 5 since the tests have gotten longer over time due to increased testing and more federation, and changes the naming scheme to be more future-proof.