[ci] Add LUCI versions of macOS ARM tests #6984
Conversation
Adds a macOS arm64 configuration, and adds the iOS build-all test in bringup mode to begin testing a LUCI migration for the ARM tests in this repository.
|
I haven't tested with |
.ci.yaml
Outdated
| # tests are reliable on the ARM infrastructure. See discussion at | ||
| # https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089 | ||
| - name: Mac_arm64 ios_build_all_plugins master | ||
| bringup: true |
There was a problem hiding this comment.
If you temporarily remove bringup: true to force this to run in presubmit on this PR does it pass? In the framework repo there's a check that complains if the key is missing, but I'm not sure if it'll complain in the plugins repo.
There was a problem hiding this comment.
Looks like ci.yaml validation failure prevents any LUCI tests from running?
There was a problem hiding this comment.
Seems like the stable one worked: https://cirrus-ci.com/task/5239301319950336
The master one timed out fetching? https://github.com/flutter/plugins/pull/6984/checks?check_run_id=10915780299
There was a problem hiding this comment.
Those are the existing Cirrus versions :)
There was a problem hiding this comment.
Oh right, that's what we're doing here.
This is the flutter/packages version of flutter/plugins#6984 to keep the CI changes in sync.
|
FWIW the flutter/packages verison of this PR worked fine. |
|
The LUCI failures here are an unrelated infra problem (already being discussed on Discord). |
|
I realized that since the only other macOS host test left in Cirrus besides this one is the macOS platform tests, which I expect to work if building works, I went ahead and added that to this PR too, in order to cut down on cycles of add-in-bringup-then-evaluate-then-enable. |
| # TODO(stuartmorgan): Swap the architecture of this and ios_platform_tests_* | ||
| # once simulator tests are reliable on the ARM infrastructure. See discussion | ||
| # at https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089 | ||
| - name: Mac_arm64 ios_build_all_plugins master |
There was a problem hiding this comment.
The second space doesn't messing up the recipe script, right? I can picture a bug related to splitting on the spaces to parse Mac_arm64, but I didn't look.
There was a problem hiding this comment.
This is the format we've been using for all of the packages and plugins LUCI tasks, and the script has been happy with it. Infra folks helped set up the initial naming structure.
|
Re-runs of these infra failures aren't triggering for some reason, but the changes to existing script files all had at least one run they passed on so I'm confident that there's no failure hidden behind the infra problem and am going to land this manually. |
* 90f447313 [ci] Increase timeouts for platform_tests (flutter/plugins#7036) * f5568e4b1 [google_sign_in] Add doc for iOS auth with SERVER_CLIENT_ID (flutter/plugins#4747) * 0c05e8d91 Roll Flutter from a815ee6 to 75680ae (58 revisions) (flutter/plugins#7048) * a4c320902 [camera]: Bump camerax_version from 1.3.0-alpha02 to 1.3.0-alpha03 in /packages/camera/camera_android_camerax/android (flutter/plugins#7061) * 8f12b27b6 [ci] Add LUCI versions of macOS ARM tests (flutter/plugins#6984) * 3843b38e2 [tool] Improve main-branch detection (flutter/plugins#7038) * d39e7569c [in_app_purchase] Prep for more const widgets (flutter/plugins#7030) * ddb9777ee [ci] Switch remaining macOS host tests to LUCI (flutter/plugins#7063) * 2edf56324 [ci] Part 1 of swapping iOS platform test arch (flutter/plugins#7064) * 35f0b1a49 [camerax] Add system services to plugin (flutter/plugins#6986) * 5dd0f41a2 [webview]: Bump mockito-inline (flutter/plugins#7056) * 1896f10ca [webview_flutter_wkwebview][webview_flutter_android] Fixes bug where the `WebView`s could not be released (flutter/plugins#6996) * a494825fa [camerax] Allow instance manager to create identical objects (flutter/plugins#7034) * 6ef73da26 [ci] Increase heavy workload memory (flutter/plugins#7065) * 9da327ca3 [various] Update to use sharedDarwinSource (flutter/plugins#7027)
This is the flutter/packages version of flutter/plugins#6984 to keep the CI changes in sync.
Adds a macOS arm64 configuration, and adds LUCI versions of the remaining Cirrus macOS-host tests (iOS build-all and macOS platform tests) in bringup mode, to begin testing a LUCI migration for the ARM tests in this repository.