[go: nahoru, domu]
Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[ci] Add LUCI versions of macOS ARM tests #6984

Merged
merged 8 commits into from
Jan 30, 2023
Merged

[ci] Add LUCI versions of macOS ARM tests #6984

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
354f270
[ci] Add an initial macOS ARM LUCI test
stuartmorgan Jan 17, 2023
8f5aeaa
Update for filename rename
stuartmorgan Jan 17, 2023
caf7775
Try presubmit
stuartmorgan Jan 26, 2023
ebdaf74
Re-add bringup
stuartmorgan Jan 27, 2023
6314d0b
Merge branch 'main' into luci-arm64-macos-initial
stuartmorgan Jan 30, 2023
275b7c2
Rename iOS platform tests to be less confusing
stuartmorgan Jan 30, 2023
c08fb7d
Add macOS platform tests too
stuartmorgan Jan 30, 2023
91e0dcd
Fix arch
stuartmorgan Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add macOS platform tests too
  • Loading branch information
@stuartmorgan
stuartmorgan committed Jan 30, 2023
commit c08fb7da1386f0a81c4c3e9215d0dc2720b264bd
43 changes: 32 additions & 11 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ targets:
target_file: mac_lint_podspecs.yaml

### macOS desktop tasks ###
# macos-platform_tests builds all the plugins on M1, so this build is run
# macos-platform_tests builds all the plugins on ARM, so this build is run
# on Intel to give us build coverage of both host types.
- name: Mac_x64 build_all_plugins master
recipe: plugins/plugins
Expand All @@ -84,33 +84,54 @@ targets:
target_file: mac_build_all_plugins.yaml
channel: stable

- name: Mac_x64 macos_platform_tests master
bringup: true # New task
recipe: plugins/plugins
timeout: 60
properties:
channel: master
add_recipes_cq: "true"
version_file: flutter_master.version
target_file: macos_platform_tests.yaml

- name: Mac_x64 macos_platform_tests stable
bringup: true # New task
recipe: plugins/plugins
presubmit: false
timeout: 60
properties:
channel: stable
add_recipes_cq: "true"
version_file: flutter_stable.version
target_file: macos_platform_tests.yaml

### iOS tasks ###
# TODO(stuartmorgan): Swap this ios_platform_tests_* once simulator
# tests are reliable on the ARM infrastructure. See discussion at
# https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089
# TODO(stuartmorgan): Swap the architecture of this and ios_platform_tests_*
# once simulator tests are reliable on the ARM infrastructure. See discussion
# at https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089
- name: Mac_arm64 ios_build_all_plugins master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second space doesn't messing up the recipe script, right? I can picture a bug related to splitting on the spaces to parse Mac_arm64, but I didn't look.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the format we've been using for all of the packages and plugins LUCI tasks, and the script has been happy with it. Infra folks helped set up the initial naming structure.

bringup: true
bringup: true # New task
recipe: plugins/plugins
timeout: 30
properties:
channel: master
add_recipes_cq: "true"
version_file: flutter_master.version
target_file: ios_build_all_plugins.yaml
channel: master

- name: Mac_arm64 ios_build_all_plugins stable
bringup: true
bringup: true # New task
recipe: plugins/plugins
timeout: 30
properties:
channel: stable
add_recipes_cq: "true"
version_file: flutter_stable.version
target_file: ios_build_all_plugins.yaml
channel: stable

# TODO(stuartmorgan): Swap this and ios_build_all_plugins once simulator
# tests are reliable on the ARM infrastructure. See discussion at
# https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089
# TODO(stuartmorgan): Swap the architecture of this and ios_build_all_plugins
# once simulator tests are reliable on the ARM infrastructure. See discussion
# at https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089
- name: Mac_x64 ios_platform_tests_1_of_4 master
recipe: plugins/plugins
timeout: 60
Expand Down
19 changes: 19 additions & 0 deletions .ci/targets/mac_platform_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
- name: build examples
script: script/tool_runner.sh
args: ["build-examples", "--macos"]
- name: xcode analyze
script: script/tool_runner.sh
args: ["xcode-analyze", "--macos"]
- name: xcode analyze deprecation
# Ensure we don't accidentally introduce deprecated code.
script: script/tool_runner.sh
args: ["xcode-analyze", "--macos", "--macos-min-version=12.3"]
- name: native test
script: script/tool_runner.sh
args: ["native-test", "--macos"]
- name: drive examples
script: script/tool_runner.sh
args: ["drive-examples", "--macos", "--exclude=script/configs/exclude_integration_macos.yaml"]