[go: nahoru, domu]

Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[ci] Add LUCI versions of macOS ARM tests #6984

Merged
merged 8 commits into from
Jan 30, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try presubmit
  • Loading branch information
stuartmorgan committed Jan 26, 2023
commit caf7775eaeb5b6720a830226906bd2bda3a0236a
2 changes: 0 additions & 2 deletions .ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ targets:
# tests are reliable on the ARM infrastructure. See discussion at
# https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089
- name: Mac_arm64 ios_build_all_plugins master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second space doesn't messing up the recipe script, right? I can picture a bug related to splitting on the spaces to parse Mac_arm64, but I didn't look.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the format we've been using for all of the packages and plugins LUCI tasks, and the script has been happy with it. Infra folks helped set up the initial naming structure.

bringup: true
recipe: plugins/plugins
timeout: 30
properties:
Expand All @@ -99,7 +98,6 @@ targets:
channel: master

- name: Mac_arm64 ios_build_all_plugins stable
bringup: true
recipe: plugins/plugins
timeout: 30
properties:
Expand Down