This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[ci] Add LUCI versions of macOS ARM tests #6984
Next
Next commit
[ci] Add an initial macOS ARM LUCI test
Adds a macOS arm64 configuration, and adds the iOS build-all test in bringup mode to begin testing a LUCI migration for the ARM tests in this repository.
- Loading branch information
commit 354f2701e4d649b7f9e22756423528a0f475f864
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,17 @@ platform_properties: | |
| ] | ||
| device_type: none | ||
| os: Windows | ||
| mac_arm64: | ||
| properties: | ||
| dependencies: >- | ||
| [ | ||
| {"dependency": "xcode", "version": "14a5294e"}, | ||
| {"dependency": "gems", "version": "v3.3.14"} | ||
| ] | ||
| os: Mac-12 | ||
| device_type: none | ||
| cpu: arm64 | ||
| xcode: 14a5294e # xcode 14.0 beta 5 | ||
| mac_x64: | ||
| properties: | ||
| dependencies: >- | ||
|
|
@@ -36,7 +47,7 @@ platform_properties: | |
| device_type: none | ||
| cpu: x86 | ||
| xcode: 14a5294e # xcode 14.0 beta 5 | ||
|
|
||
|
|
||
| targets: | ||
| ### iOS+macOS tasks *** | ||
|
|
@@ -74,7 +85,30 @@ targets: | |
| channel: stable | ||
|
|
||
| ### iOS tasks ### | ||
| # TODO(stuartmorgan): Swap this ios_platform_tests_* once simulator | ||
| # tests are reliable on the ARM infrastructure. See discussion at | ||
| # https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089 | ||
| - name: Mac_arm64 ios_build_all_plugins master | ||
| bringup: true | ||
|
There was a problem hiding this comment. If you temporarily remove There was a problem hiding this comment. Looks like ci.yaml validation failure prevents any LUCI tests from running? There was a problem hiding this comment. Seems like the stable one worked: https://cirrus-ci.com/task/5239301319950336 The master one timed out fetching? https://github.com/flutter/plugins/pull/6984/checks?check_run_id=10915780299 There was a problem hiding this comment. Those are the existing Cirrus versions :) There was a problem hiding this comment. Oh right, that's what we're doing here. |
||
| recipe: plugins/plugins | ||
| timeout: 30 | ||
| properties: | ||
| add_recipes_cq: "true" | ||
| version_file: flutter_master.version | ||
| target_file: ios_build_all_plugins.yaml | ||
| channel: master | ||
|
|
||
| - name: Mac_arm64 ios_build_all_plugins stable | ||
| bringup: true | ||
| recipe: plugins/plugins | ||
| timeout: 30 | ||
| properties: | ||
| add_recipes_cq: "true" | ||
| version_file: flutter_stable.version | ||
| target_file: ios_build_all_plugins.yaml | ||
| channel: stable | ||
|
|
||
| # TODO(stuartmorgan): Swap this and ios_build_all_plugins once simulator | ||
| # tests are reliable on the ARM infrastructure. See discussion at | ||
| # https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089 | ||
| - name: Mac_x64 ios_platform_tests_1_of_4 master | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,5 +5,6 @@ | |
|
|
||
| platform="$1" | ||
| build_mode="$2" | ||
| shift 2 | ||
| cd all_packages | ||
| flutter build "$platform" --"$build_mode" "$@" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| tasks: | ||
| - name: prepare tool | ||
| script: .ci/scripts/prepare_tool.sh | ||
| - name: create all_plugins app | ||
| script: .ci/scripts/create_all_plugins_app.sh | ||
| - name: build all_plugins for iOS debug | ||
| script: .ci/scripts/build_all_plugins.sh | ||
| args: ["ios", "debug", "--no-codesign"] | ||
| - name: build all_plugins for iOS release | ||
| script: .ci/scripts/build_all_plugins.sh | ||
| args: ["ios", "release", "--no-codesign"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second space doesn't messing up the recipe script, right? I can picture a bug related to splitting on the spaces to parse
Mac_arm64, but I didn't look.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the format we've been using for all of the packages and plugins LUCI tasks, and the script has been happy with it. Infra folks helped set up the initial naming structure.