-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[ci] Add LUCI versions of macOS ARM tests #6984
Changes from 2 commits
354f270
8f5aeaa
caf7775
ebdaf74
6314d0b
275b7c2
c08fb7d
91e0dcd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,17 @@ platform_properties: | |
] | ||
device_type: none | ||
os: Windows | ||
mac_arm64: | ||
properties: | ||
dependencies: >- | ||
[ | ||
{"dependency": "xcode", "version": "14a5294e"}, | ||
{"dependency": "gems", "version": "v3.3.14"} | ||
] | ||
os: Mac-12 | ||
device_type: none | ||
cpu: arm64 | ||
xcode: 14a5294e # xcode 14.0 beta 5 | ||
mac_x64: | ||
properties: | ||
dependencies: >- | ||
|
@@ -36,7 +47,7 @@ platform_properties: | |
device_type: none | ||
cpu: x86 | ||
xcode: 14a5294e # xcode 14.0 beta 5 | ||
|
||
|
||
targets: | ||
### iOS+macOS tasks *** | ||
|
@@ -74,7 +85,30 @@ targets: | |
channel: stable | ||
|
||
### iOS tasks ### | ||
# TODO(stuartmorgan): Swap this and ios-build_all_plugins once simulator | ||
# TODO(stuartmorgan): Swap this ios_platform_tests_* once simulator | ||
# tests are reliable on the ARM infrastructure. See discussion at | ||
# https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089 | ||
- name: Mac_arm64 ios_build_all_plugins master | ||
bringup: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you temporarily remove There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like ci.yaml validation failure prevents any LUCI tests from running? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems like the stable one worked: https://cirrus-ci.com/task/5239301319950336 The master one timed out fetching? https://github.com/flutter/plugins/pull/6984/checks?check_run_id=10915780299 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Those are the existing Cirrus versions :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh right, that's what we're doing here. |
||
recipe: plugins/plugins | ||
timeout: 30 | ||
properties: | ||
add_recipes_cq: "true" | ||
version_file: flutter_master.version | ||
target_file: ios_build_all_plugins.yaml | ||
channel: master | ||
|
||
- name: Mac_arm64 ios_build_all_plugins stable | ||
bringup: true | ||
recipe: plugins/plugins | ||
timeout: 30 | ||
properties: | ||
add_recipes_cq: "true" | ||
version_file: flutter_stable.version | ||
target_file: ios_build_all_plugins.yaml | ||
channel: stable | ||
|
||
# TODO(stuartmorgan): Swap this and ios_build_all_plugins once simulator | ||
# tests are reliable on the ARM infrastructure. See discussion at | ||
# https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089 | ||
- name: Mac_x64 ios_platform_tests_1_of_4 master | ||
|
@@ -189,7 +223,7 @@ targets: | |
timeout: 30 | ||
properties: | ||
add_recipes_cq: "true" | ||
target_file: build_all_plugins.yaml | ||
target_file: windows_build_all_plugins.yaml | ||
channel: master | ||
version_file: flutter_master.version | ||
dependencies: > | ||
|
@@ -202,7 +236,7 @@ targets: | |
timeout: 30 | ||
properties: | ||
add_recipes_cq: "true" | ||
target_file: build_all_plugins.yaml | ||
target_file: windows_build_all_plugins.yaml | ||
channel: stable | ||
version_file: flutter_stable.version | ||
dependencies: > | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
tasks: | ||
- name: prepare tool | ||
script: .ci/scripts/prepare_tool.sh | ||
- name: create all_plugins app | ||
script: .ci/scripts/create_all_plugins_app.sh | ||
- name: build all_plugins for iOS debug | ||
script: .ci/scripts/build_all_plugins.sh | ||
args: ["ios", "debug", "--no-codesign"] | ||
- name: build all_plugins for iOS release | ||
script: .ci/scripts/build_all_plugins.sh | ||
args: ["ios", "release", "--no-codesign"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second space doesn't messing up the recipe script, right? I can picture a bug related to splitting on the spaces to parse
Mac_arm64
, but I didn't look.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the format we've been using for all of the packages and plugins LUCI tasks, and the script has been happy with it. Infra folks helped set up the initial naming structure.