refactor(tests): Migrate generator tests to import shims; delete bootstrap.js
#7414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify tests/generators/index.html to import the test shims instead of using bootstrap.js to load Blockly. - Modify test/generators/webdriver.js to have it wait for the workspace to exist before calling loadSelected(). There was previously a race which index.html had been winning, but now webdriver.js is winning (and the tests failing because there is no workspace yet when start() is called.
- Delete bootstrap.js, bootstrap_helper.js, and bootstrap_done.mjs. - Remove remaining references to bootstrap.js
buildDeps is now only needed by buildCompiled, not ever for runnning in uncompressed mode, so: - Remove the deps gulp task (and the deps npm script. - Have the minify task run buildJavaScript and buildDeps directly. Additionally, the buildAdvanceCompilationTest target hasn't needed deps.js for some time (if ever), so skip having it run buildDeps entirely.
Since this is no longer used anywhere else it doesn't need to live in common.js.
1 task
rachel-fenichel
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Part of #6858.
Proposed Changes
tests/generators/index.htmltoimportthe test shims instead of usingbootstrap.jsto load Blockly.test/generators/webdriver.jsto have it wait for the workspace to exist before callingloadSelected(). There was previously a race whichindex.htmlhad been winning, but nowwebdriver.jsis winning (and the tests failing because there is no workspace yet whenstart()is called.tests/bootstrap.js,bootstrap_helper.js, andbootstrap_done.mjs.bootstrap.js.depsnpm script. ThebuildDepsgulp task is now only needed bybuildCompiled, not ever for runnning in uncompressed mode, so:depsgulp task (and thedepsnpm script that runs it).minifytask runbuildJavaScriptandbuildDepsdirectly.buildAdvanceCompilationTesttarget hasn't neededdeps.jsfor some time (if ever), so skip having it runbuildDepsentirely.const DEPS_FILEtobuild_tasks.js, since it is no longer used anywhere else and so does not need to be declared in in common.js.Behaviour After Change
Unchanged.
Reason for Changes
Remove
bootstrap.js.Test Coverage
Unchanged.
Documentation
Need to remove mention of
npm run depsfrom developer documentation.