refactor(build): Delete Closure Library #7415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was deleted in PR google#7406 as it was mainly being used to filter core/ vs. test/mocha/ deps into separate deps files - but it turns out also to be used for filtering error messages too. Oops.
This turns out to be pretty straight forward, even if it would cause crashing if one actually tried to import this module instead of just feeding it to Closure Compiler.
Replace goog.declareModuleId calls with a comment recording the former module ID for posterity (or at least until we decide how to reformat the renamings file.
For the moment we still need something to serve as base.js for the benefit of closure-make-deps, so we keep a vestigial base.js around, containing only the @provideGoog declaration.
By changing slightly the command line arguments to closure-make-deps and closure-calculate-chunks the need to have any base.js is eliminated.
rachel-fenichel
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Almost finishes resolving #6858.
Proposed Changes
Restore erroneously-deleted
filterfunction inbuildDeps.This was deleted in PR refactor(tests): Use
importinstead ofgoog.bootstrapto load Blockly in mocha tests #7406 as it was mainly being used to filtercore/vs.test/mocha/deps into separate deps files—but it turns out also to be used for filtering error messages too. Oops.Migrate advanced compilation test to ES Modules
Migrate
main.jsto TypeScript.This turns out to be pretty straight forward, even if it would cause crashing if one actually tried to import this module instead of just feeding it to Closure Compiler.
Remove
goog.declareModuleIdcalls.Replace each one with a comment recording the former module ID for posterity (or at least until we decide how to reformat the renamings file.
Delete
closure/goog/*By changing slightly the command line arguments to
closure-make-depsandclosure-calculate-chunks, even the need to have a vestigialbase.jscontianing only@declareGoogis eliminated.Behaviour Before Change
core/base.jsusedgoog.requireto obtain their dependencies.closure-make-depsandclosure-calculate-chunksdepended on the existence of abase.jsfile, containing a@declareGoogJSDoc directive.Behaviour After Change
main.tsare ES and TS modules respectively, usingimportto get their dependencies.closure-make-depsandclosure-calculate-chunksdo not need anybase.js.Reason for Changes
Eliminate code we no longer need. Make it possible to build Blockly using webpack or another minifier that's not Closure Compiler.
Test Coverage
Passes
npm test.Additional Information
This PR depends upon #7414 in order to pass tests. Once #7414 is merged, this PR must be rebased onto
developor havedevelopmerged in.