[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(advisorynotifications): generate library #10814

Merged
merged 10 commits into from
Feb 14, 2023
Merged

feat(advisorynotifications): generate library #10814

merged 10 commits into from
Feb 14, 2023

Conversation

scotthart
Copy link
Member
@scotthart scotthart commented Feb 13, 2023 •
edited by coryan
Loading

This change is Reviewable

@scotthart scotthart requested a review from a team as a code owner February 13, 2023 23:09
@product-auto-label product-auto-label bot added the api: advisorynotifications Issues related to the Advisory Notifications API. label Feb 13, 2023
@codecov
Copy link
codecov bot commented Feb 13, 2023 •
edited
Loading

Codecov Report

Base: 93.65% // Head: 93.65% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d6d2882) compared to base (f90e824).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10814   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files        1713     1713           
  Lines      153980   153980           
=======================================
+ Hits       144203   144204    +1     
+ Misses       9777     9776    -1
Impacted Files Coverage Δ
...le/cloud/storage/internal/curl_download_request.cc 87.95% <0.00%> (-0.67%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 84.21% <0.00%> (-0.66%) ⬇️
google/cloud/completion_queue_test.cc 97.13% <0.00%> (-0.20%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.49% <0.00%> (+0.33%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️
google/cloud/internal/async_connection_ready.cc 93.61% <0.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

coryan
coryan approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member
@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Optional: there is no need to update the ABI baselines for the other libraries.

scotthart
scotthart commented Feb 14, 2023
View reviewed changes
Copy link
Member Author
@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 154 files reviewed, 1 unresolved discussion (waiting on @coryan)

google/cloud/advisorynotifications/CMakeLists.txt line 39 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

This is missing cloud-docs:

google-cloud-cpp/google/cloud/accessapproval/CMakeLists.txt

Line 39 in e1de7b7

google_cloud_cpp_doxygen_targets("accessapproval" DEPENDS cloud-docs

Probably a bug I introduced in the scaffold generator.

As operator, I'll look in to the scaffold generator this week.

@scotthart scotthart merged commit 0598a5e into googleapis:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coryan coryan coryan approved these changes

Assignees
No one assigned
Labels
api: advisorynotifications Issues related to the Advisory Notifications API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scotthart @coryan @devbww