[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(advisorynotifications): generate library #10814

Merged
merged 10 commits into from
Feb 14, 2023
Merged

feat(advisorynotifications): generate library #10814

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5835eb9
feat(advisorynotifications): generate library
scotthart Feb 13, 2023
5b224ba
Run generators and format their outputs
scotthart Feb 13, 2023
399d460
updated quickstart, docs, and build infrastructure
scotthart Feb 13, 2023
f3627d6
regenerate with v1 appended to product path
scotthart Feb 13, 2023
8dbc7c0
abi dumps
scotthart Feb 13, 2023
e8168e1
update CMakeLists.txt and BUILD.bazel
scotthart Feb 13, 2023
15ceff4
fix cmake deps
scotthart Feb 14, 2023
f6b5114
update mock
scotthart Feb 14, 2023
98bc089
get quickstart executing successfully
scotthart Feb 14, 2023
d6d2882
doc fixes and regeneration fixes
scotthart Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
get quickstart executing successfully
  • Loading branch information
@scotthart
scotthart committed Feb 14, 2023
commit 98bc089f6cc6f98584c9b31ae888722ddab0bc48
1 change: 1 addition & 0 deletions ci/cloudbuild/builds/lib/integration.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ function integration::bazel_args() {
"--test_env=GOOGLE_CLOUD_PROJECT=${GOOGLE_CLOUD_PROJECT}"
"--test_env=GOOGLE_CLOUD_CPP_TEST_REGION=${GOOGLE_CLOUD_CPP_TEST_REGION}"
"--test_env=GOOGLE_CLOUD_CPP_TEST_ZONE=${GOOGLE_CLOUD_CPP_TEST_ZONE}"
"--test_env=GOOGLE_CLOUD_CPP_TEST_ORGANIZATION=${GOOGLE_CLOUD_CPP_TEST_ORGANIZATION}"
"--test_env=GOOGLE_CLOUD_CPP_TEST_SERVICE_ACCOUNT_KEYFILE=${GOOGLE_CLOUD_CPP_TEST_SERVICE_ACCOUNT_KEYFILE}"
"--test_env=GOOGLE_CLOUD_CPP_AUTO_RUN_EXAMPLES=${GOOGLE_CLOUD_CPP_AUTO_RUN_EXAMPLES}"
"--test_env=GOOGLE_CLOUD_CPP_EXPERIMENTAL_LOG_CONFIG=${GOOGLE_CLOUD_CPP_EXPERIMENTAL_LOG_CONFIG}"
Expand Down
2 changes: 2 additions & 0 deletions ci/etc/integration-tests-config.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ export GOOGLE_CLOUD_CPP_USER_PROJECT="${GOOGLE_CLOUD_PROJECT}"
export GOOGLE_CLOUD_CPP_TEST_REGION="us-central1"
# Some quickstart programs require a zone.
export GOOGLE_CLOUD_CPP_TEST_ZONE="us-central1-a"
# Some quickstart programs require an organization.
export GOOGLE_CLOUD_CPP_TEST_ORGANIZATION="1006341795026"

# This file contains an invalidated service account key. That is, the file is
# in the right format for a service account, but it is not associated with a
Expand Down
4 changes: 2 additions & 2 deletions google/cloud/advisorynotifications/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ if (BUILD_TESTING)
NAME advisorynotifications_quickstart
COMMAND
cmake -P "${PROJECT_SOURCE_DIR}/cmake/quickstart-runner.cmake"
$<TARGET_FILE:advisorynotifications_quickstart> "invalid"
GOOGLE_CLOUD_CPP_TEST_REGION)
$<TARGET_FILE:advisorynotifications_quickstart>
GOOGLE_CLOUD_CPP_TEST_ORGANIZATION GOOGLE_CLOUD_CPP_TEST_REGION)
set_tests_properties(advisorynotifications_quickstart
PROPERTIES LABELS "integration-test;quickstart")
endif ()
Expand Down
3 changes: 1 addition & 2 deletions google/cloud/advisorynotifications/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ int main(int argc, char* argv[]) try {
auto client = advisorynotifications::AdvisoryNotificationsServiceClient(
advisorynotifications::MakeAdvisoryNotificationsServiceConnection());
auto const parent =
std::string("organizations/") + argv[1] + "/locations/" + argv[2];

std::string{"organizations/"} + argv[1] + "/locations/" + argv[2];
for (auto n : client.ListNotifications(parent)) {
if (!n) throw std::move(n).status();
std::cout << n->DebugString() << "\n";
Expand Down
3 changes: 1 addition & 2 deletions google/cloud/advisorynotifications/quickstart/quickstart.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ int main(int argc, char* argv[]) try {
auto client = advisorynotifications::AdvisoryNotificationsServiceClient(
advisorynotifications::MakeAdvisoryNotificationsServiceConnection());
auto const parent =
std::string("organizations/") + argv[1] + "/locations/" + argv[2];

std::string{"organizations/"} + argv[1] + "/locations/" + argv[2];
for (auto n : client.ListNotifications(parent)) {
if (!n) throw std::move(n).status();
std::cout << n->DebugString() << "\n";
Expand Down