[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: audit use of dense JSON encoding #5330

Closed
shollyman opened this issue Sep 18, 2020 · 2 comments · Fixed by #5337 or #5341
Closed

BigQuery: audit use of dense JSON encoding #5330

shollyman opened this issue Sep 18, 2020 · 2 comments · Fixed by #5337 or #5341
Assignees
@jskeet
Labels
api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@shollyman
Copy link

Request

Review this library to ensure dense encoding (e.g. prettyPrint=false) is specified when possible when communicating with the BigQuery API methods.

Additional Context

Pretty printed JSON responses from server can have significant response size inflation for complex objects. BigQuery data APIs tend to exacerbate this. Library can improve performance by using dense encoding, particular for underlying methods like jobs.getQueryResults and tabledata.list that may supply large, complex JSON responses.

Info about prettyPrint system API parameter:
https://cloud.google.com/apis/docs/system-parameters

Internal (for Googlers)

See issue 168725137
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Sep 18, 2020
@jskeet
Copy link
Collaborator
jskeet commented Sep 18, 2020

Will look at this next week.

@jskeet jskeet self-assigned this Sep 18, 2020
@jskeet jskeet added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Sep 18, 2020
jskeet added a commit to jskeet/google-cloud-dotnet that referenced this issue Sep 22, 2020
@jskeet
Disable pretty printing in BigQuery unless explicitly requested
fc31a29 
This is client-wide, and can only be set on the BigQueryClientBuilder (to avoid an explosion of BigQueryClientImpl constructors in the long run). It is then propagated to all requests. It defaults to false.

In order to test this change properly, I've had to also add a Service property to BigQueryClientBuilder, but that seems appropriate anyway.

Fixes googleapis#5330.
@jskeet jskeet mentioned this issue Sep 22, 2020
Merged
jskeet added a commit to jskeet/google-cloud-dotnet that referenced this issue Sep 22, 2020
@jskeet
Disable pretty printing in BigQuery unless explicitly requested
5a3a308 
This is client-wide, and can only be set on the BigQueryClientBuilder (to avoid an explosion of BigQueryClientImpl constructors in the long run). It is then propagated to all requests. It defaults to false.

In order to test this change properly, I've had to also add a Service property to BigQueryClientBuilder, but that seems appropriate anyway.

Fixes googleapis#5330.
jskeet added a commit that referenced this issue Sep 22, 2020
@jskeet
Disable pretty printing in BigQuery unless explicitly requested
14be654 
This is client-wide, and can only be set on the BigQueryClientBuilder (to avoid an explosion of BigQueryClientImpl constructors in the long run). It is then propagated to all requests. It defaults to false.

In order to test this change properly, I've had to also add a Service property to BigQueryClientBuilder, but that seems appropriate anyway.

Fixes #5330.
@jskeet jskeet mentioned this issue Sep 23, 2020
Merged
jskeet added a commit to jskeet/google-cloud-dotnet that referenced this issue Sep 23, 2020
@jskeet
Release Google.Cloud.BigQuery.V2 version 2.1.0
ff01f86 
Changes in this release:

- [Commit 14be654](googleapis@14be654): feat: Disable pretty printing in BigQuery unless explicitly requested. Fixes [issue 5330](googleapis#5330).
- [Commit 909f568](googleapis@909f568): docs: Clarify the scopes used by BigQueryClient.Create and CreateAsync
jskeet added a commit that referenced this issue Sep 23, 2020
@jskeet
Release Google.Cloud.BigQuery.V2 version 2.1.0
7c5c220 
Changes in this release:

- [Commit 14be654](14be654): feat: Disable pretty printing in BigQuery unless explicitly requested. Fixes [issue 5330](#5330).
- [Commit 909f568](909f568): docs: Clarify the scopes used by BigQueryClient.Create and CreateAsync
@jskeet
Copy link
Collaborator
jskeet commented Sep 23, 2020

This is now released in version 2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jskeet jskeet

Labels
api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
2 participants
@jskeet @shollyman