Disable pretty printing in BigQuery unless explicitly requested #5337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanda-tarafa
approved these changes
Sep 22, 2020
| @@ -66,6 +88,7 @@ public override async Task<BigQueryClient> BuildAsync(CancellationToken cancella | |||
| protected override void Validate() | |||
| { | |||
| base.Validate(); | |||
| // TODO: Validate that if Service is set, no credentials are set? | |||
There was a problem hiding this comment.
That would be inline with what we do with the invokers in the gRPC equivalents. Can't Service here just be internal? We can always make it public later on if there's a need for it apart from testing.
There was a problem hiding this comment.
We could definitely make it internal, yes - I just don't like the idea that we can test stuff but others can't. Still, it means we don't need to worry about the TODO for now. Will remove this TODO, but add a note on the newly-internal property.
This is client-wide, and can only be set on the BigQueryClientBuilder (to avoid an explosion of BigQueryClientImpl constructors in the long run). It is then propagated to all requests. It defaults to false. In order to test this change properly, I've had to also add a Service property to BigQueryClientBuilder, but that seems appropriate anyway. Fixes googleapis#5330.
fc31a29
to
5a3a308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is client-wide, and can only be set on the BigQueryClientBuilder (to avoid an explosion of BigQueryClientImpl constructors in the long run). It is then propagated to all requests. It defaults to false.
In order to test this change properly, I've had to also add a Service property to BigQueryClientBuilder, but that seems appropriate anyway.
Fixes #5330.