[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run cargo update #694

Merged
merged 6 commits into from
Oct 22, 2021
Merged

run cargo update #694

merged 6 commits into from
Oct 22, 2021

Conversation

bacongobbler
Copy link
Collaborator
@bacongobbler bacongobbler commented Oct 20, 2021 •
edited
Loading

No description provided.

@bacongobbler
run cargo update
8cc741a 
Signed-off-by: Matthew Fisher <matt.fisher@fishworks.io>
@thomastaylor312
Copy link
Member

Looks like one of the updates broke an API

@thomastaylor312 thomastaylor312 mentioned this pull request Oct 20, 2021
Merged
@thomastaylor312
Copy link
Member

I think I figured it out. Because we are on an alpha build of notify (to pick up the better features in the 5.0 series), the latest update broke it. I am fixing it now and will push to this branch

@thomastaylor312
Updates to use the new notify API
9e5b858 
Signed-off-by: Taylor Thomas <taylor@oftaylor.com>
@thomastaylor312
Copy link
Member
thomastaylor312 commented Oct 20, 2021 •
edited
Loading

I have no idea why the e2e tests are failing here. I just ran them on a ubuntu machine just fine, but the error logs are showing a could not get CSI plugin endpoint when it definitely looks like things are running (I can see the csi-provisioner doing its job)

@thomastaylor312
Copy link
Member

Oooh, just got it to happen after running again

@thomastaylor312 thomastaylor312 force-pushed the cargo-update branch 3 times, most recently from ae8afdf to 9e5b858 Compare October 20, 2021 23:45
@bacongobbler
switch to ipv4 ip family
1eeacc1 
Signed-off-by: Matthew Fisher <matt.fisher@fishworks.io>
@bacongobbler
DEBUG
57ab7b0 
Signed-off-by: Matthew Fisher <matt.fisher@fishworks.io>
@bacongobbler
grab host IP using getent
61d783d 
Signed-off-by: Matthew Fisher <matt.fisher@fishworks.io>
@bacongobbler
attach stdin
dcad8b3 
Signed-off-by: Matthew Fisher <matt.fisher@fishworks.io>
@bacongobbler bacongobbler merged commit a50f64d into krustlet:main Oct 22, 2021
@bacongobbler bacongobbler deleted the cargo-update branch October 22, 2021 18:02
@thomastaylor312 thomastaylor312 mentioned this pull request Oct 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomastaylor312 thomastaylor312 thomastaylor312 approved these changes

@kflansburg kflansburg Awaiting requested review from kflansburg kflansburg is a code owner

@technosophos technosophos Awaiting requested review from technosophos technosophos is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bacongobbler @thomastaylor312