-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove oci-distribution #695
remove oci-distribution #695
Conversation
Looks like similar build failures to #694 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go once we solve the underlying build failures and rebase on that work
cd20539
to
bfe4dc3
Compare
new location: https://github.com/krustlet/oci-distribution Signed-off-by: Matthew Fisher <matt.fisher@fishworks.io> Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
bfe4dc3
to
4fd1549
Compare
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
@bacongobbler I think with a rebase this should be good to go |
After re-fetching from upstream:
|
I thought we had fixed the cargo deny stuff recently |
@bacongobbler Let's go ahead an ignore the |
Any thoughts on when this PR can be merged? I'm working on a custom kubelet implementation and using the In my implementation, I'm also making use of the Unfortunately, I ran into the issue regarding manifest lists not being supported yet in The ideal scenario would be (in order):
I realize I could provide my own |
Thanks for reaching out @rickrain! So normally our rule is that maintainers merge their own PRs once reviewed. The other PR you referred to is awaiting review from someone with more OCI experience than myself. So I think we can do all of those things. I'll start out by pinging @bacongobbler and see if he is ok with me merging this. Then we can do a follow up PR with a version bump as soon as the other feature is added |
Just heard back from @bacongobbler. Going to go ahead and merge this |
I'm okay with merging this. Last we revisited this PR, we were waiting on fixing up Windows CI failures, but it looks like that's stalled out. Good to go otherwise |
Thanks @thomastaylor312 and @bacongobbler for the quick response and action. |
new location: https://github.com/krustlet/oci-distribution
related to #690