New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden operation constraints from AnyType to CIRType #90

Open

bcardosolopes opened this issue May 26, 2023 · 2 comments

Labels

good first issue

Member

bcardosolopes commented

Now that #81 is fixed, we need to change operations constraints to only accept CIR types, simple example:

...
let arguments = (ins Arg<CmpOpKind, "cmp kind">:$kind,
                       AnyType:$lhs, AnyType:$rhs);

Should become:

...
let arguments = (ins Arg<CmpOpKind, "cmp kind">:$kind,
                       CIRType:$lhs, CIRType:$rhs);

And additional changes to CIRDialect.cpp and whatnots.

The text was updated successfully, but these errors were encountered:

bcardosolopes added the good first issue label

Collaborator

Lancern commented

Hi. Recently I'm working on this issue. I noticed that clangir does not have floating-point types. C/C++ floating-point values are lowered to MLIR values with the built-in f32 and f64 type, instead of some cir.f32 or cir.f64 type. Is this intentional? I'll have to include AnyFloat in the CIRType type constraint which may allow non-CIR floating-point types.

Lancern added a commit to Lancern/clangir that referenced this issue


          [CIR] replace AnyType with CIR_AnyType

bc54331

This commit addresses llvm#90. It introduces a new type constraint
"CIR_AnyType" which allows CIR types and MLIR floating-point types.
Present AnyType constraints are replaced with the new CIR_AnyType
constraint.

Lancern mentioned this issue

[CIR] replace AnyType with CIR_AnyType #371

Merged

Member Author

bcardosolopes commented

It's not intentional, we actually want CIR specific types for floating point, see #78. I haven't seen progress in the past couple months, so if you are interested you could work on that too.

Lancern mentioned this issue

[CIR] introduce CIR floating-point types #385

Merged

5 tasks

bcardosolopes pushed a commit that referenced this issue


          [CIR] Replace AnyType with CIR_AnyType (#371)

4562fc8

This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.

lanza pushed a commit that referenced this issue


          [CIR] Replace AnyType with CIR_AnyType (#371)

d4b5bc7

This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.

bcardosolopes pushed a commit that referenced this issue


          [CIR] introduce CIR floating-point types (#385)

941cb1d

This PR adds a dedicated `cir.float` type for representing
floating-point types. There are several issues linked to this PR: #5,
#78, and #90.

lanza pushed a commit that referenced this issue


          [CIR] Replace AnyType with CIR_AnyType (#371)

2d4adfe

This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.

lanza pushed a commit that referenced this issue


          [CIR] introduce CIR floating-point types (#385)

347d829

This PR adds a dedicated `cir.float` type for representing
floating-point types. There are several issues linked to this PR: #5,
#78, and #90.

eZWALT pushed a commit to eZWALT/clangir that referenced this issue


          [CIR] Replace AnyType with CIR_AnyType (llvm#371)

96bb98f

This PR addresses llvm#90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.

eZWALT pushed a commit to eZWALT/clangir that referenced this issue


          [CIR] Replace AnyType with CIR_AnyType (llvm#371)

e05262f

This PR addresses llvm#90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.

eZWALT pushed a commit to eZWALT/clangir that referenced this issue


          [CIR] introduce CIR floating-point types (llvm#385)

b6e6a37

This PR adds a dedicated `cir.float` type for representing
floating-point types. There are several issues linked to this PR: llvm#5,
llvm#78, and llvm#90.

lanza pushed a commit that referenced this issue


          [CIR] Replace AnyType with CIR_AnyType (#371)

790f7ea

This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.

lanza pushed a commit that referenced this issue


          [CIR] introduce CIR floating-point types (#385)

This PR adds a dedicated `cir.float` type for representing
floating-point types. There are several issues linked to this PR: #5,
#78, and #90.

lanza pushed a commit that referenced this issue


          [CIR] Replace AnyType with CIR_AnyType (#371)

ea6a6fa

This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.

lanza pushed a commit that referenced this issue


          [CIR] introduce CIR floating-point types (#385)

ab6226f

This PR adds a dedicated `cir.float` type for representing
floating-point types. There are several issues linked to this PR: #5,
#78, and #90.

eZWALT pushed a commit to eZWALT/clangir that referenced this issue


          [CIR] Replace AnyType with CIR_AnyType (llvm#371)

64aaf13

This PR addresses llvm#90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.

eZWALT pushed a commit to eZWALT/clangir that referenced this issue


          [CIR] introduce CIR floating-point types (llvm#385)

0ba447b

This PR adds a dedicated `cir.float` type for representing
floating-point types. There are several issues linked to this PR: llvm#5,
llvm#78, and llvm#90.

lanza pushed a commit that referenced this issue


          [CIR] Replace AnyType with CIR_AnyType (#371)

6a0e742

This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.

lanza pushed a commit that referenced this issue


          [CIR] introduce CIR floating-point types (#385)

b82fdb0

This PR adds a dedicated `cir.float` type for representing
floating-point types. There are several issues linked to this PR: #5,
#78, and #90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment