[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR] replace AnyType with CIR_AnyType #371

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

Lancern
Copy link
Collaborator
@Lancern Lancern commented Dec 28, 2023

This PR addresses #90. It introduces a new type constraint CIR_AnyType which allows CIR types and MLIR floating-point types. Present AnyType constraints are replaced with the new CIR_AnyType constraint.

This commit addresses llvm#90. It introduces a new type constraint
"CIR_AnyType" which allows CIR types and MLIR floating-point types.
Present AnyType constraints are replaced with the new CIR_AnyType
constraint.
Copy link
Collaborator
@sitio-couto sitio-couto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

clang/include/clang/CIR/Dialect/IR/CIRTypes.td Outdated Show resolved Hide resolved
Copy link
Member
@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after minor nit

clang/include/clang/CIR/Dialect/IR/CIRTypes.td Outdated Show resolved Hide resolved
@bcardosolopes bcardosolopes merged commit 4562fc8 into llvm:main Jan 9, 2024
6 checks passed
@Lancern Lancern deleted the cir-type-constraints branch January 10, 2024 12:43
lanza pushed a commit that referenced this pull request Jan 29, 2024
This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
lanza pushed a commit that referenced this pull request Mar 23, 2024
This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
This PR addresses llvm#90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
This PR addresses llvm#90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
lanza pushed a commit that referenced this pull request Apr 29, 2024
This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
lanza pushed a commit that referenced this pull request Apr 29, 2024
This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
This PR addresses llvm#90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
lanza pushed a commit that referenced this pull request Apr 29, 2024
This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants