Port some templates to Twig #13207
Merged
Port some templates to Twig #13207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #13207 +/- ##
==========================================
- Coverage 54.55% 54.4% -0.15%
==========================================
Files 469 470 +1
Lines 69553 69888 +335
==========================================
+ Hits 37942 38023 +81
- Misses 31611 31865 +254 |
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
|
Thanks! While touching the tests, feel free to change their logic as well, the byte to byte verification of rendered HTML is not really optimal. |
4 tasks
|
Related to #13297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maurício Meneghini Fauth mauriciofauth@gmail.com
Before submitting pull request, please check that every commit: