[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port some templates to Twig #13236

Merged
merged 2 commits into from
May 4, 2017
Merged

Conversation

MauricioFauth
Copy link
Member

Signed-off-by: Maurício Meneghini Fauth mauriciofauth@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@codecov
Copy link
codecov bot commented May 4, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@574ac65). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master   #13236   +/-   ##
=========================================
  Coverage          ?   54.41%           
=========================================
  Files             ?      471           
  Lines             ?    69922           
  Branches          ?        0           
=========================================
  Hits              ?    38051           
  Misses            ?    31871           
  Partials          ?        0

@nijel nijel merged commit 61f2940 into phpmyadmin:master May 4, 2017
@nijel nijel self-assigned this May 4, 2017
@nijel nijel added this to the 4.7.1 milestone May 4, 2017
@nijel
Copy link
Contributor
nijel commented May 4, 2017

Merged, thanks for your contribution!

@MauricioFauth MauricioFauth deleted the templates branch May 4, 2017 14:23
@MauricioFauth
Copy link
Member Author

@nijel, Why 4.7.1 milestone? Both #13100 and #13207 have 4.8.0 milestone.

@nijel nijel modified the milestones: 4.8.0, 4.7.1 May 5, 2017
@nijel
Copy link
Contributor
nijel commented May 5, 2017

Sorry, it was merged to master, I've set wrong milestone here...

@MauricioFauth
Copy link
Member Author

Related to #13297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants