[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Implemented Date of creation of PDF #169

Merged
merged 12 commits into from
Mar 14, 2021
Merged

Feature: Implemented Date of creation of PDF #169

merged 12 commits into from
Mar 14, 2021

Conversation

Saransh-cpp
Copy link
Contributor

Addressing #99

Changes

  1. Added Date feature to every PDF's card
  2. Now the Hive boxes, both starred and pdfs contain a list of lists at position 0. For ex -
[
   ['/this/is/some/path/file1.pdf', 'date1'], 
   ['/path/2/file2.pdf','date2']
]
  1. Integrated every existing feature to incorporate this change in the storage style.

Screenshot

Now only the picture feature is something that needs to be worked upon, please review and let me know if you want any changes in this PR.

(CWoC and GSSoC participant)

arteevraina
arteevraina reviewed Mar 13, 2021
View reviewed changes
lib/PDFConversion.dart Outdated
@@ -67,7 +68,11 @@ class _PDFConversion extends State<PDFConversion> {

// SharedPreferences sharedPreferences = await SharedPreferences.getInstance();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Saransh-cpp! Could you remove these instances of commented code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!:)

arteevraina
arteevraina suggested changes Mar 13, 2021
View reviewed changes
Copy link
@arteevraina arteevraina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR locally. It worked fine. I think it can be merged after the required changes.

@arteevraina arteevraina added the Level-4 Implementing new features label Mar 13, 2021
@arteevraina
Copy link
arteevraina commented Mar 13, 2021 •
edited
Loading

@Saransh-cpp Lint tests are failing can you please fix them ?

@Saransh-cpp
Copy link
Contributor Author

@Saransh-cpp Lint tests are failing can you please fix them ?

Some of them are being worked upon by someone else, I will fix all the issues related to the PR I created.

@arteevraina
Copy link

@Saransh-cpp Lint tests are failing can you please fix them ?

Some of them are being worked upon by someone else, I will fix all the issues related to the PR I created.

Cool ! My bad I forgot that someone else was working on it.

arteevraina
arteevraina approved these changes Mar 13, 2021
View reviewed changes
Copy link
@arteevraina arteevraina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work !

@Saransh-cpp
Copy link
Contributor Author

I fixed some small random lint issue too

Lint issues now (Not related to my PR)

  1. File names (being worked up in another PR)
  2. Image is deprecated and Image.provider should be used now but I can't figure out right now how to use it in our case.
  3. WatchBoxBuilder has been deprecated. (Will learn how to use the new one)

@smaranjitghose smaranjitghose merged commit 6850fb9 into smaranjitghose:main Mar 14, 2021
@pr-triage pr-triage bot added the PR: merged label Mar 14, 2021
@smaranjitghose smaranjitghose removed the Level-4 Implementing new features label Mar 14, 2021
@smaranjitghose smaranjitghose added gssoc21 GirlScript Summer of Code 2021 Level3 GSSOC New features, major bug fixing. and removed PR: reviewed-approved PR: reviewed-changes-requested labels Mar 14, 2021
@Saransh-cpp
Copy link
Contributor Author
Saransh-cpp commented Mar 14, 2021 •
edited
Loading

@smaranjitghose whenever you get time, please add the CrossWOC and difficulty labels.

@smaranjitghose
Copy link
Owner

@smaranjitghose whenever you get time, please add the CrossWOC and difficulty labels.

CrossWoC evaluation is over. I have added it to all your PRs that were merged or raised before the deadline

@Saransh-cpp
Copy link
Contributor Author

@smaranjitghose whenever you get time, please add the CrossWOC and difficulty labels.

CrossWoC evaluation is over. I have added it to all your PRs that were merged or raised before the deadline

The dates were updated on their website, I confirmed in their discord and they said that the PRs merged till 12th March have been counted till now in the leader board and they will keep updating the leader board till 28th March which is the last date for the program. Can you please confirm this with them?

@smaranjitghose
Copy link
Owner

@smaranjitghose whenever you get time, please add the CrossWOC and difficulty labels.

CrossWoC evaluation is over. I have added it to all your PRs that were merged or raised before the deadline

The dates were updated on their website, I confirmed in their discord and they said that the PRs merged till 12th March have been counted till now in the leader board and they will keep updating the leader board till 28th March which is the last date for the program. Can you please confirm this with them?

Sure. I'll DM them

@smaranjitghose
Copy link
Owner

@Saransh-cpp Ya, just confirmed. Its' upto 28th. I'll update your scores accordingly then

@Saransh-cpp Saransh-cpp mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arteevraina arteevraina arteevraina approved these changes

Assignees
No one assigned
Labels
CrossWOC gssoc21 GirlScript Summer of Code 2021 Hard Level3 GSSOC New features, major bug fixing. PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Saransh-cpp @arteevraina @smaranjitghose