[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added image preview to PDF card in home screen #195

Merged
merged 3 commits into from
Mar 18, 2021

Conversation

Saransh-cpp
Copy link
Contributor
@Saransh-cpp Saransh-cpp commented Mar 16, 2021

Closes #193
Hopefully finally Closes #99

Changes

  1. The preview photo is added in the Hive box in a similar fashion as the date is added.
  2. All the storage style changes have been discussed in Feature: Implemented Date of creation of PDF #169, and this PR uses that change of storage style to incorporate the storing of image too.

Screenshots

Please let me know if you want any changes in this PR, thanks!

(CWoC and GSSoC participant)

Copy link
Collaborator
@anushbhatia anushbhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20210318_032728_com example doclense

@Saransh-cpp
Copy link
Contributor Author

@anushbhatia was this error faced on starting up the app or after you created a PDF and opened the home screen?

@anushbhatia
Copy link
Collaborator

@anushbhatia was this error faced on starting up the app or after you created a PDF and opened the home screen?

startup on the home screen

@Saransh-cpp
Copy link
Contributor Author

@anushbhatia was this error faced on starting up the app or after you created a PDF and opened the home screen?

startup on the home screen

This might be because you already have some PDFs in your app/Hive box which do not have a preview image as they were created before this code was written. Can you please once uninstall the app from your device then install it using the code from this branch and then let me know if this error still pops up?

@anushbhatia
Copy link
Collaborator

@anushbhatia was this error faced on starting up the app or after you created a PDF and opened the home screen?

startup on the home screen

This might be because you already have some PDFs in your app/Hive box which do not have a preview image as they were created before this code was written. Can you please once uninstall the app from your device then install it using the code from this branch and then let me know if this error still pops up?

🙌Sure let me check that.

@anushbhatia
Copy link
Collaborator

Screenshot_20210318_155537_com example doclense
Overflow of icons

@Saransh-cpp
Copy link
Contributor Author

@anushbhatia please check now

@Saransh-cpp
Copy link
Contributor Author

Should I also fix the pixel overflow in imageview and filterview screens or is someone working on that?

@anushbhatia
Copy link
Collaborator

Should I also fix the pixel overflow in imageview and filterview screens or is someone working on that?

Nobody is working you can raise the pr.

@anushbhatia anushbhatia merged commit 008d24f into smaranjitghose:main Mar 18, 2021
@anushbhatia anushbhatia added gssoc21 GirlScript Summer of Code 2021 Level3 GSSOC New features, major bug fixing. labels Mar 18, 2021
@Saransh-cpp
Copy link
Contributor Author

@anushbhatia could you please add the CrossWOC and the level labels on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc21 GirlScript Summer of Code 2021 Level3 GSSOC New features, major bug fixing. PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a preview on home page Improving the style of displaying the pdf's in home page
2 participants