[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXP] Build a storage plugin interface. #1368

Open
wants to merge 9 commits into
base: latest
Choose a base branch
from
Open

[EXP] Build a storage plugin interface. #1368

wants to merge 9 commits into from

Conversation

ctb
Copy link
Contributor
@ctb ctb commented Mar 5, 2021 •
edited
Loading

This is an attempt to generalize #1349 with generic storage plugins, one of which may happen to be a ZipFileLinearIndex.

Ref "let's have plugins!" #1353.

Comments very welcome :)

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link
codecov bot commented Mar 5, 2021 •
edited
Loading

Codecov Report

Merging #1368 (d96ca06) into latest (b866935) will decrease coverage by 0.16%.
The diff coverage is 78.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1368      +/-   ##
==========================================
- Coverage   89.15%   88.99%   -0.17%     
==========================================
  Files         123      124       +1     
  Lines       18596    18765     +169     
  Branches     1433     1448      +15     
==========================================
+ Hits        16580    16699     +119     
- Misses       1780     1829      +49     
- Partials      236      237       +1
Flag Coverage Δ
python 94.14% <78.92%> (-0.27%) ⬇️
rust 67.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_sbt.py 100.00% <ø> (ø)
tests/test_index.py 90.74% <55.55%> (-9.26%) ⬇️
src/sourmash/sourmash_args.py 91.12% <81.25%> (-1.33%) ⬇️
src/sourmash/index.py 91.30% <85.71%> (-1.80%) ⬇️
src/sourmash/storage/__init__.py 92.10% <92.10%> (ø)
src/sourmash/sbt.py 84.38% <100.00%> (+0.24%) ⬆️
tests/test_api.py 100.00% <100.00%> (ø)
tests/test_cmd_signature.py 100.00% <100.00%> (ø)
src/sourmash/lca/command_summarize.py 79.20% <0.00%> (-1.60%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b866935...d96ca06. Read the comment docs.

@ctb ctb changed the base branch from latest to add/zipfile_index March 12, 2021 23:43
This was referenced Mar 24, 2021
Merged
Open
Base automatically changed from add/zipfile_index to latest April 3, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ctb