[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix MinHash merge of abund + noabund objects (rust). #1395

Open
wants to merge 9 commits into
base: latest
Choose a base branch
from

Conversation

ctb
Copy link
Contributor
@ctb ctb commented Mar 14, 2021

KmerMinHash::merge in src/core/src/sketch/minhash.rs is leaving the abundance vectors in an inconsistent state when merging two MinHash objects, one with track_abundance=True and one without. This PR adds tests for several but not all of the conditions that aren't being handled, and also proposes some (probably incorrect) Rust-level code fixes.

I think a better solution might be to simply declare this kind of merge to be not allowed, and to force people to flatten the abund MinHash if they want to merge with a no-abund MinHash.

@luizirber your input solicited!

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb ctb added the rust label Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant