Report number of matches in 'sourmash search' docstring. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed docstring: search appear to report up to the top three matches, not the top top matches.
Current coverage is 83.10% (diff: 100%)@@ master #55 diff @@
==========================================
Files 8 8
Lines 1018 1018
Methods 37 37
Messages 0 0
Branches 44 44
==========================================
Hits 846 846
Misses 155 155
Partials 17 17
|
|
#56 was merge. If the checks are passing the PR should be good to go. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed docstring: search appear to report up to the top three matches, not the top top matches.
make testDid it pass the tests?make coverageIs the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?
Fixed docstring: search appear to report up to the top three matches, not the top top matches.