[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] JSON schema #578

Open
wants to merge 6 commits into
base: latest
Choose a base branch
from
Open

[WIP] JSON schema #578

wants to merge 6 commits into from

Conversation

luizirber
Copy link
Member

@jiarong asked for this about a month ago and I forgot to open a PR.

Create JSON schemas for minhash and SBTs

TODO

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link
codecov bot commented Dec 14, 2018 •
edited
Loading

Codecov Report

Merging #578 into master will increase coverage by 4.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
+ Coverage   83.89%   88.43%   +4.54%     
==========================================
  Files          98       31      -67     
  Lines        9126     4790    -4336     
  Branches        0       46      +46     
==========================================
- Hits         7656     4236    -3420     
+ Misses       1470      551     -919     
- Partials        0        3       +3
Flag Coverage Δ
#rusttests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sourmash/schema/__init__.py 100.00% <100.00%> (ø)
sourmash/command_compute.py 76.30% <0.00%> (-21.34%) ⬇️
sourmash/compare.py 89.55% <0.00%> (-10.45%) ⬇️
sourmash/lca/command_summarize.py 82.79% <0.00%> (-7.21%) ⬇️
sourmash/sbt_storage.py 85.39% <0.00%> (-6.73%) ⬇️
sourmash/sbtmh.py 85.00% <0.00%> (-4.91%) ⬇️
sourmash/sbt.py 85.53% <0.00%> (-3.33%) ⬇️
sourmash/lca/command_classify.py 86.36% <0.00%> (-2.53%) ⬇️
sourmash/lca/command_index.py 90.70% <0.00%> (-2.53%) ⬇️
sourmash/fig.py 88.88% <0.00%> (-0.25%) ⬇️
... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f27f4f...c92830b. Read the comment docs.

@luizirber
Copy link
Member Author

also see: https://github.com/wolverdude/GenSON

@luizirber luizirber mentioned this pull request Oct 29, 2019
Open
@luizirber luizirber modified the milestones: 4.0, pre-4.0 Jan 14, 2020
@luizirber luizirber added the 4.0 issues to address for a 4.0 release label Jun 8, 2020
@luizirber
Copy link
Member Author

see also: https://github.com/GREsau/schemars

@luizirber luizirber changed the base branch from master to latest August 4, 2020 23:27
@luizirber luizirber mentioned this pull request Aug 5, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
4.0 issues to address for a 4.0 release
Projects
None yet
Milestone
pre-4.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@luizirber